define api endpoints and contract #15
Conversation
|
|
||
| @Post('content/:userDsnpId/broadcast') | ||
| @HttpCode(202) | ||
| async broadcast(@Param('userDsnpId') userDsnpId: string, @Body() broadcastDto: BroadcastDto): Promise<AnnouncementResponseDto> { |
There was a problem hiding this comment.
Not this PR, but I wonder how we will reuse the announcement structure while still waiting to upload the files.
I guess the upload endpoint could return the ipfs.io CID url (as it knows the upload parameters, we can generate the correct CID) and so while not uploaded yet, the incoming broadcastDto That way it is just matching the CID from the ifps url to trigger the release to IPFS from the upload queue.
There was a problem hiding this comment.
I'm not sure if I follow the reuse scenario that you are mentioning. Would you please elaborate on that?
There was a problem hiding this comment.
Mostly how the assetIds strings are used. If those assetIds were urls of the form https://ipfs.io/ipfs/[CID], then we could just insert them into the Broadcast/ReplyDto from the calling service. Then in here, it would just be a matter of parsing, validating, and triggering off the actual ipfs pins of those files inside the BroadcastDto.
There was a problem hiding this comment.
I think there are some confusion about how we are imagining this might work. I'll create a diagram before starting to implement that part to make sure we are on the same page.
Description
We need to define the endpoints and dtos related to content publishing api.
close #4
Details
Verification evidence