-
Notifications
You must be signed in to change notification settings - Fork 0
Update dependencies, fix lints and set updated packages #107
Conversation
@@ -50,7 +50,7 @@ export class BatchAnnouncer { | |||
const writer = await ParquetWriter.openStream(parquetSchema, publishStream as any, writerOptions); | |||
// eslint-disable-next-line no-restricted-syntax | |||
for await (const announcement of announcements) { | |||
await writer.appendRow(announcement); | |||
await writer.appendRow(announcement as Record<string, any>); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No clue why after updates, this error started popping, got fixed by a cast but not sure if its correct
> ERROR in ./apps/worker/src/batch_announcer/batch.announcer.ts:53:30
> TS2345: Argument of type 'Announcement' is not assignable to parameter of type 'Record<string, unknown>'.
> Type '{ announcementType: AnnouncementType; fromId: string; } & TombstoneFields' is not assignable to type 'Record<string, unknown>'.
> Index signature for type 'string' is missing in type '{ announcementType: AnnouncementType; fromId: string; } & TombstoneFields'.
> 51 | // eslint-disable-next-line no-restricted-syntax
> 52 | for await (const announcement of announcements) {
> > 53 | await writer.appendRow(announcement);
> | ^^^^^^^^^^^^
> 54 | }
> 55 | await writer.close();
> 56 |
>
> webpack 5.90.1 compiled with 1 error in 13268 ms
>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked and this is an issue with Parquetjs. I'll work on getting a fix in over there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@saraswatpuneet I found the correct fix and it isn't in the Parquetjs side.
The TypedAnnouncement type needs to explicitly extend intersect with the Record<string, unknown>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will issue an update for this
Co-authored-by: Wil Wade <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙇
@@ -50,7 +50,7 @@ export class BatchAnnouncer { | |||
const writer = await ParquetWriter.openStream(parquetSchema, publishStream as any, writerOptions); | |||
// eslint-disable-next-line no-restricted-syntax | |||
for await (const announcement of announcements) { | |||
await writer.appendRow(announcement); | |||
await writer.appendRow(announcement as Record<string, any>); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked and this is an issue with Parquetjs. I'll work on getting a fix in over there.
Details
namespace
errorsTests