Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/issue 763 refine import rule handling #999

Merged
merged 6 commits into from
Nov 18, 2022
Merged

Bug/issue 763 refine import rule handling #999

merged 6 commits into from
Nov 18, 2022

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Nov 12, 2022 •
edited
Loading

Related Issue

Found some gaps in our @import rule handling

/* expected */
@tailwind base;
@tailwind components;
@tailwind utilities;

/* actual */
@tailwind base}
@tailwind components}
@tailwind utilities}

/* not support at all!! */
@import url('https://fonts.googleapis.com/css?family=Raleway&display=swap');

Summary of Changes

  1. Support remote @import url
  2. Support for "plain" @ rule, per Tailwind style
  3. Add test cases

TODO

  1. Add support for remote @import url
  2. Add support for "plain" at rule, per Tailwind style
  3. Add test cases
  4. Should probably review / apply more @ rule cases 😅

@thescientist13 thescientist13 added bug Something isn't working P0 Critical issue that should get addressed ASAP CLI alpha.4 v0.27.0 labels Nov 12, 2022
@thescientist13 thescientist13 added this to the 1.0 milestone Nov 12, 2022
This was referenced Nov 12, 2022
Closed
Merged
Merged
Merged
Merged
@thescientist13 thescientist13 changed the base branch from master to release/0.27.0 November 12, 2022 23:12
@thescientist13 thescientist13 marked this pull request as ready for review November 13, 2022 00:07
@thescientist13 thescientist13 merged commit a0805ee into release/0.27.0 Nov 18, 2022
@thescientist13 thescientist13 deleted the bug/issue-763-refine-import-rule-handling branch November 18, 2022 01:46
thescientist13 added a commit that referenced this pull request Nov 23, 2022
@thescientist13
Bug/issue 763 refine import rule handling (#999)
300a73b 
* setting up test cases for additional import rule examples

* support non relative @import url rule

* support arbitrary @ rules

* @supports and single declaration handling

* test for more @ rules

* update related specs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alpha.4 bug Something isn't working CLI P0 Critical issue that should get addressed ASAP v0.27.0
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.
1 participant
@thescientist13