Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix incorrect HUD noopener implementation #975

Merged
merged 2 commits into from
Sep 22, 2022
Merged

fix incorrect HUD noopener implementation #975

merged 2 commits into from
Sep 22, 2022

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Aug 21, 2022 •
edited
Loading

Related Issue

Noticed noopener was spelled wrong inside the <a> tag of the HUD. But also did some reading and learned

  1. In newer browsers (anything that would support WCs at least) noopener is implied when using target="_blank" ✅
  2. If using noreferrer, it basically behaves like noopener as well ✅ ✅

I guess we could do this anywhere else in the site? 🤔

Summary of Changes

  1. Change HUD to just use noreferrer

@thescientist13 thescientist13 added bug Something isn't working question Further information is requested CLI labels Aug 21, 2022
@thescientist13 thescientist13 changed the base branch from master to release/0.27.0 September 3, 2022 22:50
@thescientist13 thescientist13 merged commit 0c44d19 into release/0.27.0 Sep 22, 2022
@thescientist13 thescientist13 deleted the bug/hud-incorrect-noopener-attribute branch September 22, 2022 12:57
@thescientist13 thescientist13 mentioned this pull request Sep 22, 2022
Merged
27 tasks
@thescientist13 thescientist13 changed the title fix incorrect HUD noopener implementation fix incorrect HUD noopener implementation Oct 1, 2022
thescientist13 added a commit that referenced this pull request Nov 3, 2022
@thescientist13
fix incorrect HUD noopener implementation (#975)
afb50cd
thescientist13 added a commit that referenced this pull request Nov 12, 2022
@thescientist13
fix incorrect HUD noopener implementation (#975)
48a7517
thescientist13 added a commit that referenced this pull request Nov 23, 2022
@thescientist13
fix incorrect HUD noopener implementation (#975)
12c1e86
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alpha.0 bug Something isn't working CLI question Further information is requested v0.27.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thescientist13