Guides/issue 689 improve docs for theme pack developers #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uilding with Greenwood while developing a theme pack
thescientist13
deleted the
guides/issue-689-improve-docs-for-theme-pack-developers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
resolves #689
Summary of Changes
Found a not too bad work around for ensuring theme pack plugin authors can use Greenwood to run all commands when developing a theme pack
One observation left over seems to be an odd discrepancy between how
process.env.__GWD_COMMAND__is getting handled / set? 🤔TODO
Anyway, I think is good enough to close this particular issue out at least, and concentrate on the overall experience desired being tracked in #682 .