Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/issue 1302 install fails when no args are provided #1303

Merged
merged 3 commits into from
Nov 8, 2024

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Nov 7, 2024

Related Issue

resolve #1302

Summary of Changes

  1. A bit hacky *, this should now check to make sure the last arg is not the script entry filename, and if so, assume no args have been passed
  2. Upgrades to latest version of gallinago to fix forwarding args implementation

* I know this is all a bit of a hack and the previous work around for #1280 are a bit ugly (only because I could not shoe-horn the feature into inquirer), and so a proper refactor / re-write will be coming soon via #1279

@thescientist13 thescientist13 added bug Something isn't working Init labels Nov 7, 2024
@thescientist13 thescientist13 changed the title bug/issue 1302 install fails with no args bug/issue 1302 install fails when no args are provided Nov 7, 2024
@thescientist13
Copy link
Member Author

Ah yeah, on Windows we get different formatting for paths. Should be easy enough to account for though

[
  'C:\\Users\\owenbuckley\\.nvm\\versions\\node\\v18.20.0\\bin\\node.exe',
  'C:\\Users\\owenbuckley\\Workspace\\greenwood\\packages\\init\\src\\index.js'
]

@thescientist13 thescientist13 merged commit 1ce74c7 into master Nov 8, 2024
8 checks passed
@thescientist13 thescientist13 deleted the bug/issue-1302-install-fails-with-no-args branch November 8, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Init
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installer fails when no args are provided
1 participant