Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/issue 1008 netlify adapter plugin #1128

Merged

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Jul 23, 2023

Related Issue

relates to #1008

WIP demo - ProjectEvergreen/greenwood-demo-adapter-netlify#4

Summary of Changes

  1. Created Netlify adapter plugin package
  2. Added test cases

Had to do a temp work around for #1136

TODO

  1. Add multiple API route and SSR page tests
  2. Refactor out some duplicate output generation code
  3. netlify.toml integration / generation needed (might be a race condition if the build output is needed when the Netlify build starts though?
  4. manifest output options? - https://github.com/netlify/zip-it-and-ship-it#options - don't think it is needed
  5. bespoke copying of execute route module and API assets directories? - related to output consolidation and is being tracked in single file bundles (SFBs) for SSR page and API routes #1118
  6. need to handle all Request / Response properties in adapter entry point, like headers and method
  7. update to plugin list in website docs
  8. README
    • Netlify configuration / setup
    • features
    • caveats
  9. Fix Windows specs
  10. Local Netlify CLI / context integration? (or track as own issue)
  11. Integrate with bug/issue 1137 have adapted SSR pages return text/html content type #1138 and update test cases
  12. Caveats tracking

@thescientist13 thescientist13 added documentation Greenwood specific docs Plugins Greenwood Plugins alpha.2 discussion tied to an ongoing discussion or meeting notes feature New feature or request v0.29.0 Adapter labels Jul 23, 2023
@thescientist13 thescientist13 added this to the 1.0 milestone Jul 23, 2023
@thescientist13 thescientist13 self-assigned this Jul 23, 2023
@thescientist13 thescientist13 marked this pull request as ready for review August 6, 2023 01:17
@thescientist13 thescientist13 linked an issue Aug 7, 2023 that may be closed by this pull request
@thescientist13 thescientist13 force-pushed the feature/issue-1008-netlify-adapter-plugin branch from f31e6c2 to 62efdaa Compare August 12, 2023 14:32
@thescientist13 thescientist13 merged commit 17debc9 into release/0.29.0 Aug 12, 2023
8 checks passed
@thescientist13 thescientist13 deleted the feature/issue-1008-netlify-adapter-plugin branch August 12, 2023 15:06
@thescientist13 thescientist13 mentioned this pull request Aug 12, 2023
25 tasks
thescientist13 added a commit that referenced this pull request Aug 12, 2023
* create initial working version of a netlify adapter plugin

* add test case for greeting API route adapter

* add test case for SSR page output

* README clarifications

* add fragments API and HTTP method support from Netlify event

* file output setup and zipping refactoring

* auto-generate _redirects file based on pages and APIs

* redirects should be rewrites instead

* document recommended Netlify project configuration setup

* document caveats

* link to demonstration repo

* document adapter netlify on custom plugins page

* add netlify-cli as a dependency

* Netlify CLI integration and clarifications

* disable linting due to typescript version conflicts

* clarify redirects and rewrites in README

* update pathname handling for windows interop

* add test coverage for SSR pages content type

* README refresh
thescientist13 added a commit that referenced this pull request Nov 9, 2023
* create initial working version of a netlify adapter plugin

* add test case for greeting API route adapter

* add test case for SSR page output

* README clarifications

* add fragments API and HTTP method support from Netlify event

* file output setup and zipping refactoring

* auto-generate _redirects file based on pages and APIs

* redirects should be rewrites instead

* document recommended Netlify project configuration setup

* document caveats

* link to demonstration repo

* document adapter netlify on custom plugins page

* add netlify-cli as a dependency

* Netlify CLI integration and clarifications

* disable linting due to typescript version conflicts

* clarify redirects and rewrites in README

* update pathname handling for windows interop

* add test coverage for SSR pages content type

* README refresh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Adapter alpha.2 discussion tied to an ongoing discussion or meeting notes documentation Greenwood specific docs feature New feature or request Plugins Greenwood Plugins v0.29.0
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Static and Serverless Hosting Runtime Adapters
1 participant