Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/issue 957 node 18 upgrade #1014

Merged
merged 4 commits into from
Dec 10, 2022
Merged

Feature/issue 957 node 18 upgrade #1014

merged 4 commits into from
Dec 10, 2022

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Dec 2, 2022 •
edited
Loading

Related Issue

resolves #957

Summary of Changes

  1. Make Node 18.12.x minimum supported Greenwood version
  2. Replace instances of node-fetch with native fetch

TODO

Make refactoring ticket for

  1. Refactor Greenwood to use JSON modules - refactor project to use JSON Modules #1015
  2. Refactor specs to use fetch instead of request - refactor tests to use fetch instead of request #1016
  3. Linux GitHub Actions are failing. 🤔 
    node: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.28' not found (required by node)
Error: Process completed with exit code 1.

@thescientist13 thescientist13 added documentation Greenwood specific docs breaking feature New feature or request Plugins Greenwood Plugins CLI dependencies Pull requests that update a dependency file labels Dec 2, 2022
This was referenced Dec 2, 2022
Open
Closed
@thescientist13 thescientist13 changed the base branch from master to release/0.28.0 December 10, 2022 19:30
@thescientist13 thescientist13 changed the base branch from release/0.28.0 to master December 10, 2022 19:36
@thescientist13 thescientist13 changed the base branch from master to release/0.28.0 December 10, 2022 19:39
@thescientist13 thescientist13 force-pushed the feature/issue-957-node-18-upgrade branch from 08b7353 to 2b03ac0 Compare December 10, 2022 19:50
@thescientist13 thescientist13 merged commit a3f667f into release/0.28.0 Dec 10, 2022
@thescientist13 thescientist13 deleted the feature/issue-957-node-18-upgrade branch December 10, 2022 20:01
thescientist13 added a commit that referenced this pull request Feb 7, 2023
@thescientist13
Feature/issue 957 node 18 upgrade (#1014)
1fa5a2e 
* upgrade node 18

* update node version documentation

* adopt native fetch

* upgrade Ubuntu version for Linux GitHub Actions
thescientist13 added a commit that referenced this pull request Apr 9, 2023
@thescientist13
Feature/issue 957 node 18 upgrade (#1014)
3526e91 
* upgrade node 18

* update node version documentation

* adopt native fetch

* upgrade Ubuntu version for Linux GitHub Actions
thescientist13 added a commit that referenced this pull request Apr 9, 2023
@thescientist13
Feature/issue 957 node 18 upgrade (#1014)
eabc682 
* upgrade node 18

* update node version documentation

* adopt native fetch

* upgrade Ubuntu version for Linux GitHub Actions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking CLI dependencies Pull requests that update a dependency file documentation Greenwood specific docs feature New feature or request Plugins Greenwood Plugins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

upgrade to Node v18 as minimum supported version
1 participant
@thescientist13