-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QA] 웨이팅 부재 다이얼로그 처리, 새로고침에 딜레이 추가 #282
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit cc0cfed)
wjdtkdgns777
changed the title
[QA] 웨이팅 부재 토스트메시지 추가, 새로고침에 딜레이 추가
[QA] 웨이팅 부재 다이얼로그 처리, 새로고침에 딜레이 추가
Oct 25, 2024
웨이팅 화면에 로딩이 지금 하나도 없네요 LoadingWheel 보이게 설정 해야할것같아여 |
그리고 init 할때는 delay(1000) 필요 없을거같거든요 init 이랑 refresh 일때 케이스 나눠서 refresh 일때만 delay 걸리게 해주는게 좋을 것 같슴다 |
훨 보기 좋아졌군.. |
easyhooon
approved these changes
Oct 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
웨이팅부분을 체크해서 부재처리된거면 처리하라는 다이얼로그가 뜨도록 처리했습니다
또 새로고침에 딜레이를 추가했는데 이 방식 말씀하신게 맞을까요?
그리고.. 왜인지 pulltorefresh에 코드를... 잘못 작성한 부분이 있었습니다 발견해서 다행인데 뭔짓을 했던거지...