[design] 웨이팅탭에 새로고침 버튼 추가 #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easyhooon
reviewed
Oct 14, 2024
| Row( | ||
| modifier = Modifier.clickable { | ||
| onWaitingUiAction(WaitingUiAction.OnRefresh) | ||
| multipleEventsCutter.processEvent { |
There was a problem hiding this comment.
이거 가져오지 말고 clickableSingle { } 쓰면 됩니다
|
저도 pull to refresh가 그렇게 좋은 UI/UX라고 생각하지 않는 사람으로서 동의합니다. 리스트화면에서는 어느정도 친숙한 UI/UX라고 생각은 하는데, 그렇지않은 화면의 경우, pull to refresh를 지원하는지 한눈에 알긴 어렵드라구요 그럼에도 배민같은 앱처럼 지원은 default로 하는 느낌이라 버튼 눌러 새로고침과 더불러 둘다 지원하면 괜찮을것같아요 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이 화면을 볼때마다 유저가 pull to refresh인걸 모를거같다는 느낌이 계속 들더라구요
바텀탭에 연결된 전체화면이라 그런가.. 뭐랄까 UIUX를 배웠으면 명확히 설명했을텐데 그런느낌이 있네요 ㅋㅋㅋ
그래서 석준님과 협의해 스탬프와 같이 새로고침을 추가해주었습니다. pull to refresh도 일단은 계속 둘까 합니다