TASK-410 Not working switch between actual and base versions & TASK-420 always same default group in worker drawer #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qwebeck
changed the title
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Zrobiłem tak, ale błąd się nie pojawił |
pectom
reviewed
Mar 24, 2021
|
|
||
| export type SelectionMatrix = boolean[][]; | ||
|
|
||
| export function areDimesionsEqual(matrix1: unknown[][], matrix2: unknown[][]): boolean { |
There was a problem hiding this comment.
@Qwebeck Mógłbyś opisać jaki był problem?
There was a problem hiding this comment.
Tak, sorki, że nie opisałem wcześniej.
Problem był taki, że w momencie kiedy zmienialiśmy stan grafiku z aktualnego na bazowy, to nie komponent się renderował od nowa, ale macierz się nie odświeżała, i miała mniejszy rozmiar.
Komponent sekcji jest renderowany w taki sposób
<RowComponent
selection={[...selectionMatrix[rowInd]]}
I pojawiała się sytuacja w której próbowaliśmy zrobić spread na undeinfed i mieliśmy bug.
Ale nie jestem pewny czy to jest na rozwiązuje problem, czy to rozwiązanie które wprowadziłem sedno problemu, czy tylko eliminuje jeden z jego przejawów.
There was a problem hiding this comment.
Oki, to zobaczymy czy będzie to nawracać. Na razie działa lepiej, więc mergujemy.
Umknął mi jeden punkt: |
Qwebeck
changed the title
pectom
approved these changes
Mar 24, 2021
prenc
pushed a commit
that referenced
this pull request
Mar 26, 2021
…20 always same default group in worker drawer (#312)
prenc
added a commit
that referenced
this pull request
Mar 26, 2021
* TASK-321 Introduce workers' teams (#293) * TASK-362 Use excel spreadsheet to import and export shifts (#291) * TASK-408 Add information about worker team to management table (#298) * TASK-408 Adds information about worker group to managament table and allows to change worker group * Fixes z-index * Adds groups sotring * TASK-411 Export with worker groups (#299) * Change error folding section display (#308) * Fix corrupted schedule test case (#310) * TASK-330 Track app version and store it presistently (#273) * TASK-327 Use worker shifts from state (#264) * TASK-394 New free shifts (#304) * TASK-410 Not working switch between actual and base versions & TASK-420 always same default group in worker drawer (#312) * TASK-423 sticky month header (#314) * TASK-416 Sort workers in groups && TASK-406 Display worker markers on schedule (#309) * TASK-409 Show import bug messages for all import buttons (#307) * TASK-423 Remove background of schedule's header (#315) * First push <3 * Done?. * Ready for review. * Ready for review. * Unreal changes. * Removed comments, reverted to develop styling. * Epic changes. * HEIGHT FIXED. Co-authored-by: Tomasz Pęcak <[email protected]> * TASK-422 Fixes export of worker calendar (#313) * TASK-425 disables edit buttons (#318) * TASK-386 Enhance comprehensibility of error messages (#302) * Add mapping to uid for employee info contractType and workerGroup keys (#311) * Add bunch of prerelease fixes (#321) * TASK-419 Style non-working shifts consistently (#316) * TASK-412 Bug: drawer button does not stick bottom (#325) * TASK-386 Enhance comprehensibility of error messages (follow-up) (#326) * Fix shift types that was not defined (#327) * Fix cell input (#328) * Fix onBlur when no value provided (#329) * Fix logs from shifts (#331) * Fix work norm calculation for not working shifts (#332) Co-authored-by: Bohdan <[email protected]> Co-authored-by: Paulina <[email protected]> Co-authored-by: Tomasz Pęcak <[email protected]> Co-authored-by: Maciej Bielech <[email protected]> Co-authored-by: Jan Ślażyński <[email protected]> Co-authored-by: Ehevi <[email protected]> Co-authored-by: Szymon Fugas <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Mar 26, 2021
## [1.0.2](v1.0.1...v1.0.2) (2021-03-26) ### Performance Improvements * **App:** Release v2.0.0 ([#323](#323)) ([cdc701d](cdc701d)), closes [#293](#293) [#291](#291) [#298](#298) [#299](#299) [#308](#308) [#310](#310) [#273](#273) [#264](#264) [#304](#304) [#312](#312) [#314](#314) [#309](#309) [#307](#307) [#315](#315) [#313](#313) [#318](#318) [#302](#302) [#311](#311) [#321](#321) [#316](#316) [#325](#325) [#326](#326) [#327](#327) [#328](#328) [#329](#329) [#331](#331) [#332](#332)
github-actions bot
pushed a commit
that referenced
this pull request
Mar 26, 2021
## [1.0.2](v1.0.1...v1.0.2) (2021-03-26) ### Performance Improvements * **App:** Release v2.0.0 ([#323](#323)) ([cdc701d](cdc701d)), closes [#293](#293) [#291](#291) [#298](#298) [#299](#299) [#308](#308) [#310](#310) [#273](#273) [#264](#264) [#304](#304) [#312](#312) [#314](#314) [#309](#309) [#307](#307) [#315](#315) [#313](#313) [#318](#318) [#302](#302) [#311](#311) [#321](#321) [#316](#316) [#325](#325) [#326](#326) [#327](#327) [#328](#328) [#329](#329) [#331](#331) [#332](#332)
prenc
added a commit
that referenced
this pull request
Mar 26, 2021
* TASK-321 Introduce workers' teams (#293) * TASK-362 Use excel spreadsheet to import and export shifts (#291) * TASK-408 Add information about worker team to management table (#298) * TASK-408 Adds information about worker group to managament table and allows to change worker group * Fixes z-index * Adds groups sotring * TASK-411 Export with worker groups (#299) * Change error folding section display (#308) * Fix corrupted schedule test case (#310) * TASK-330 Track app version and store it presistently (#273) * TASK-327 Use worker shifts from state (#264) * TASK-394 New free shifts (#304) * TASK-410 Not working switch between actual and base versions & TASK-420 always same default group in worker drawer (#312) * TASK-423 sticky month header (#314) * TASK-416 Sort workers in groups && TASK-406 Display worker markers on schedule (#309) * TASK-409 Show import bug messages for all import buttons (#307) * TASK-423 Remove background of schedule's header (#315) * First push <3 * Done?. * Ready for review. * Ready for review. * Unreal changes. * Removed comments, reverted to develop styling. * Epic changes. * HEIGHT FIXED. Co-authored-by: Tomasz Pęcak <[email protected]> * TASK-422 Fixes export of worker calendar (#313) * TASK-425 disables edit buttons (#318) * TASK-386 Enhance comprehensibility of error messages (#302) * Add mapping to uid for employee info contractType and workerGroup keys (#311) * Add bunch of prerelease fixes (#321) * TASK-419 Style non-working shifts consistently (#316) * TASK-412 Bug: drawer button does not stick bottom (#325) * TASK-386 Enhance comprehensibility of error messages (follow-up) (#326) * Fix shift types that was not defined (#327) * Fix cell input (#328) * Fix onBlur when no value provided (#329) * Fix logs from shifts (#331) * Fix work norm calculation for not working shifts (#332) Co-authored-by: Bohdan <[email protected]> Co-authored-by: Paulina <[email protected]> Co-authored-by: Tomasz Pęcak <[email protected]> Co-authored-by: Maciej Bielech <[email protected]> Co-authored-by: Jan Ślażyński <[email protected]> Co-authored-by: Ehevi <[email protected]> Co-authored-by: Szymon Fugas <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Mar 26, 2021
## [1.0.2](v1.0.1...v1.0.2) (2021-03-26) ### Performance Improvements * **App:** Release v2.0.0 ([#323](#323)) ([cdc701d](cdc701d)), closes [#293](#293) [#291](#291) [#298](#298) [#299](#299) [#308](#308) [#310](#310) [#273](#273) [#264](#264) [#304](#304) [#312](#312) [#314](#314) [#309](#309) [#307](#307) [#315](#315) [#313](#313) [#318](#318) [#302](#302) [#311](#311) [#321](#321) [#316](#316) [#325](#325) [#326](#326) [#327](#327) [#328](#328) [#329](#329) [#331](#331) [#332](#332) * **App:** Release v2.0.0 ([#333](#333)) ([230ae80](230ae80)), closes [#293](#293) [#291](#291) [#298](#298) [#299](#299) [#308](#308) [#310](#310) [#273](#273) [#264](#264) [#304](#304) [#312](#312) [#314](#314) [#309](#309) [#307](#307) [#315](#315) [#313](#313) [#318](#318) [#302](#302) [#311](#311) [#321](#321) [#316](#316) [#325](#325) [#326](#326) [#327](#327) [#328](#328) [#329](#329) [#331](#331) [#332](#332)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jak odtworzyć błąd z selection matrix
Na developie: