Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #199 | Proper Furniture Unloading #200

Merged
merged 1 commit into from
Mar 31, 2024

Conversation

ogidevs
Copy link
Contributor

@ogidevs ogidevs commented Mar 30, 2024

Overview

Provide a brief overview of the purpose of this pull request
Fixes furniture unloading when leaving property.

Details

So, as I understood, once table.remove is used and entry is actually removed, leftovers in table shifts, thus changing the indexes. As a result, we do not iterate through all the furniture.

UI Changes / Functionality

/

Testing Steps

Enter other player's property with placed furniture.
Leave the property and enter yours.

  • [YES] Did you test the changes you made?
  • [YES] Did you test core functionality of the script to ensure your changes do not regress other areas?
  • [YES] Did you test your changes in multiplayer to ensure it works correctly on all clients?

@ogidevs
Copy link
Contributor Author

ogidevs commented Mar 30, 2024

#199

@MonkeyWhisper MonkeyWhisper merged commit 87de962 into Project-Sloth:main Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants