Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added block_counter variable to a preprocessor check, minor bug. #6596

Merged
merged 3 commits into from
Apr 16, 2023

Conversation

AlTimofeyev
Copy link
Contributor

@AlTimofeyev AlTimofeyev commented Apr 4, 2023

Issue

This PR closes issue #6589. There was a minor bug where the variable block_counter in file osrm-backend/include/util/range_table.hpp was considered as "set but not used" during the build phase, causing an error. That variable was added to a preprocessor guard to solve this issue.

Tasklist

Requirements / Relations

Link any requirements here. Other pull requests this PR is based on?

@AlTimofeyev
Copy link
Contributor Author

One of the workflow runs failed when checking the CHANGELOG.md file with error:

Run ./scripts/check_taginfo.py taginfo.json profiles/car.lua
clang-format-10 is /usr/bin/clang-format-10
ERROR ON LINE 13:       - ADDED: Print tracebacks for Lua runtime errors [#6564](https://github.com/Project-OSRM/osrm-backend/pull/6564)    
    ERROR: changelog entries must end with an issue or PR link in Markdown format
Error: Process completed with exit code 1.

I'm guessing it could have been because I messed with the order of the Misc items in the changelog a little, so I just put it back the way it was in the master branch.

@SiarheiFedartsou SiarheiFedartsou merged commit 0ca9131 into Project-OSRM:master Apr 16, 2023
@SiarheiFedartsou
Copy link
Member

Thanks!

@AlTimofeyev
Copy link
Contributor Author

Of course! Glad I could help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants