make it tolerant of TBB 2020

[datendelphin]

I know I am too late to the party, as 5.27 is already released.
With regard to #6300 it is not that difficult to make OSRM agnostic of tbb version. I implemented it for the fossgis routing server, as that one is on debian, which might take another few months until the next stable version is released.
So probably too late to be relevant, but if anyone is in a similar position, here would be the patch.

[DennisOSRM]

@SiarheiFedartsou what's your opinion on this?

[SiarheiFedartsou]

Well, on one hand I don’t see any issues with that - it is not a big deal to support both versions, but when do we think we can completely drop compatibility with tbb 2020? When Debian will officially start having newer versions in package repos?

btw at the moment we use Debian as base image too and just build newer TBB from sources

osrm-backend/docker/Dockerfile

Line 10 in 95c4523

RUN NPROC=${BUILD_CONCURRENCY:-$(nproc)} && \

[datendelphin]

In my opinion, a good time to remove 2020 support would be in the next OSRM release after debian bookworm was released.
I have no problem with building a newer tbb from source. But it has drawbacks. The release coming with debian was tested with the rest of the system. And it's just more convenient. Less surprises for users (currently no clear error message that TBB is too old). If there is a compelling reason, like it is significantly more efficient, that would be another case.

[SiarheiFedartsou]

a good time to remove 2020 support would be in the next OSRM release after debian bookworm was released.

Google says Bookworm will likely be released in Mid 2023. Should we really spend time on support of both versions for 6 months? These days OSRM development is quite slow and I doubt we even will be able to release some new version of OSRM before release of new Debian.

At the same time it is not a big deal to merge and maintain this and I can help with it if really needed - just sharing some doubts...

WDYT?

[datendelphin]

Yes I feel the same way, that's why I wrote I am too late to the party ;)
Depends a bit on how often #6497 pops up. Might be enough to just have this PR as a quick fix for people hitting it. Not sure about github behavior, but maybe I can just close it, but it will still be found via the bug report.

[datendelphin]

Debian bookworm was released in the mean time

[woodpeck]

I just tried to build OSRM on a stock RedHat 9.2 and the tbb coming with that was too old apparently, and this patch helped me to get this working.