Fix/ch distance offsets #5057
Merged
Fix/ch distance offsets #5057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghoshkaj
force-pushed
the
fix/ch-distance-offsets
branch
from
fdc5920 to
cea83e1
Compare
|
Awesome! 💯 looks good to me! The correct thing would probably be.... finding regression tests... but I'd be ok with merging too 🙈 |
chaupow
approved these changes
Apr 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Found an offset bug that seems not to have been triggered in the CH code, but we found it while working on the MLD code.
Tasklist
Requirements / Relations
#4990