-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shared storage cache #4988
Closed
ghoshkaj
wants to merge
206
commits into
compute-annotations-for-table-at-runtime
from
shared_storage_cache
Closed
Shared storage cache #4988
ghoshkaj
wants to merge
206
commits into
compute-annotations-for-table-at-runtime
from
shared_storage_cache
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the check should cover merging of roads at intersections similar to https://www.openstreetmap.org/node/53020993#map=18/37.86590/-122.25083
Rename module partition to partitioner. This cultivates naming used in existing modules like extractor, customizer, etc. - noun vs verb (word partition is both though).
Make entry points of individual pipeline stages responsible for configuring the task scheduler with requested number of threads passed in corresponding configuration bundle (ie. follow extractor).
Intersection analysis occupy in osrm::extractor::intersection namespace and guidance code osrm::guidance
We now build using GCC 7 and Clang 5 and only build binaries for node 8.x and 4.x.
This PR makes the path of host `.osm.pbf` file clearer.
…and facade.GetUncompressedReverseDurations
ghoshkaj
force-pushed
the
shared_storage_cache
branch
from
April 1, 2018 17:18
bc1ca99
to
e57c949
Compare
ghoshkaj
force-pushed
the
shared_storage_cache
branch
from
April 1, 2018 17:53
358ba75
to
181c4c7
Compare
log stuff comments to self on how to compute durations moar notes
calculate packed_path_from_source_to_middle debugging the retrievePackedPathFromSearchSpace function implementation more debugging so much clearner and it works!
commentary answers to the questions I had as comments everything that was broken last night works this morning! what?!?! notes cache is partway working
the computeDurationForEdge method remove all vestiges of step 5 it works! only 2 test failures to solve! 2 moar bugs sqaushed so 2 more tests fixed!! but found more failing cuke tests! comment out all std::outs comment out cache clean up the code move vector creation and allocation to outside of loop
…and facade.GetUncompressedReverseDurations attempt to clean up hack clean up hack
rebase against vectors->range pr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Use a shared storage cache to compare against performance of the threadlocal cache in #4876. This PR is to test out which is faster and keep the implementation that is faster. Related to cache considerations detailed here.
Tasklist
Requirements / Relations
#4876