Fixes in guidance #4929
Merged
Fixes in guidance #4929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxidase
force-pushed
the
guidance/unrelated-bugfixes-for-obvious
branch
from
b61416d to
2f62266
Compare
oxidase
force-pushed
the
guidance/unrelated-bugfixes-for-obvious
branch
from
2f62266 to
38c567b
Compare
TheMarex
approved these changes
Mar 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
PR is a follow up of review #4867 and extracts some unrelated commits:
Merge IntersectionShapeData and IntersectionEdgeGeometry
Cleanup EBGF code
Adjust Straight direction modifiers of side roads in driveway handler.
The driveway handler now checks if both a main road and a service road have straight directions and adjusts the service road direction to slight left or right.
Handle oneways in get_forward_backward_by_key.
In case of one way roads
get_forward_backward_by_keyusesforward or way:get_value_by_key(key)andbackward or way:get_value_by_key(key)even if one direction is not allowed. The change is related to the turn lanes counting at segregated intersections in guidance analysis code. The change affects handling of:forwardand:backwardtags forhov:lanes,toll,route,lanes:psv,turn:lanes,vehicle:lanes.Don't use obviousness for links bifurcations.
For all link bifurcations classified as forks obviousness will be ignored (related PR Don't use obvious directions at ramp bifurcations #4896)
/cc @TheMarex
Please read our documentation on release and version management.
If your PR is still work in progress please attach the relevant label.
Tasklist
Requirements / Relations
Blocks #4867