Collect stats on MLD and CH performance in computing table plugin annotations with a cache by implementing a dummy cache #4820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghoshkaj
changed the title
ghoshkaj
force-pushed
the
compute-annotations-for-table-at-runtime
branch
from
93a703f to
350bc6f
Compare
ghoshkaj
force-pushed
the
compute-annotations-for-table-at-runtime
branch
3 times, most recently
from
1fbf347 to
714b74a
Compare
TheMarex
reviewed
Jan 25, 2018
| std::cout << " weight: " << result.shortest_path_weight << std::endl; | ||
| std::cout << " duration: " << result.duration() <<"\n" << std::endl << std::endl; | ||
|
|
||
| weights_table.emplace_back(result.shortest_path_weight); |
There was a problem hiding this comment.
The weight_table is already pre-filled with values, we can write directly to it using weight_table[row_index * number_of_targets + col_index].
There was a problem hiding this comment.
Oh right, we pre-fill with INVALID_EDGE_WEIGHT here: https://github.com/Project-OSRM/osrm-backend/pull/4820/files#diff-81e2dc0f0a96c3d1a3fd7e43ee98a7f3R169
right. Thanks! 😄
ghoshkaj
force-pushed
the
compute-annotations-for-table-at-runtime
branch
5 times, most recently
from
505fa89 to
f4c29fc
Compare
added more logs
accurate stats
ghoshkaj
force-pushed
the
compute-annotations-for-table-at-runtime
branch
2 times, most recently
from
80159bc to
9ca8415
Compare
ghoshkaj
force-pushed
the
compute-annotations-for-table-at-runtime
branch
from
9ca8415 to
292058d
Compare
TheMarex
changed the title
ghoshkaj
changed the title
ghoshkaj
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Implementing the second comment in this issue: Compute annotations for table plugin at runtime
Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?