Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install clang-3.8 via mason binary #2496

Merged
merged 1 commit into from
Jun 4, 2016
Merged

Install clang-3.8 via mason binary #2496

merged 1 commit into from
Jun 4, 2016

Conversation

springmeyer
Copy link
Contributor

We needed to disable clang-3.8 builds in e7159ad due to LLVM apt servers going offline (http://lists.llvm.org/pipermail/llvm-foundation/2016-June/000025.html).

This brings back testing of clang-3.8 via a mason package downloaded from s3, which should be fast and stable.

Bonus: this package supports -fsanitize=<things> like address and integer.

@springmeyer
Copy link
Contributor Author

This is working now after fixing the clang-3.8 builds to be proper Release builds and disabling openmp, which is not working yet in the clang-3.8 binaries.

As far as openmp, we have a few routes:

    1. keep the above patch that disables openmp
    1. rebuild clang-3.8 binaries again to fully remove partial/broken openmp support

I am out of the office till next Monday. When I'm back I can take a look at 2).

@springmeyer springmeyer force-pushed the clang-comes-back branch 2 times, most recently from 1067fa0 to 75e2932 Compare June 3, 2016 00:40
@springmeyer
Copy link
Contributor Author

  1. rebuild clang-3.8 binaries again to fully remove partial/broken openmp support

Was able to do this today, so I reverted the disabling of openmp, and the builds are working now. This is ready to merge once travis is all green.

@daniel-j-h
Copy link
Member

Interested in how OpenMP support is broken in LLVM 3.8. Care to elaborate?

@TheMarex TheMarex force-pushed the clang-comes-back branch from 75e2932 to dfafe7d Compare June 4, 2016 10:15
@TheMarex TheMarex merged commit dfafe7d into master Jun 4, 2016
@TheMarex TheMarex deleted the clang-comes-back branch June 4, 2016 10:15
@springmeyer
Copy link
Contributor Author

Interested in how OpenMP support is broken in LLVM 3.8. Care to elaborate?

@daniel-j-h it was compiled into the binary but then programs that linked it needed to load the libomp.so library at runtime. That would not work with a mason provided clang++ since the libomp.so is not in the default shared library paths. We could get it working by setting LD_LIBRARY_PATH to the custom libomp.so location. But since clang++ builds have not been using omp previously I did not want to address that in this pull.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants