Modify profiles to use Lua 5.2+ without needing compatibility flags #1457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Todo:
|
|
@TheMarex ah, looks like the cmake files are still looking for 5.1 — I'll fix. |
|
Sorry dropped the ball here. Will rebase and add following symbolic links. |
Symbolic links are a _bad_ idea with lua script. Lua will search at the place of the symbolic link for modules _not_ at the actual location of the script.
|
Looks good. Merging. |
TheMarex
added a commit
that referenced
this pull request
May 16, 2015
Modify profiles to use Lua 5.2+ without needing compatibility flags
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the deprecation of
modulein Lua 5.2+, the current approach only works in 5.2 with compatibility flags, and doesn't work in Lua 5.3 at all. This alternate approach allows us to use Lua 5.2 with or without compatibility flags and fixes issues raised in #1454.Note: the change I introduce here to
lib/access.lua's nil return reflects the way it had been inlined in car.lua — before changing thelib/access.luavalue, two car barrier tests (features/car/barrier.feature) were failing; after the change all cucumber tests pass. I'm not entirely confident as to why this is as I am by no means a lua expert… @emiltin would you mind taking a look?I'm curious to see how upgrading affects travis (especially wrt questions about using LuaJIT, #1442) (I'm developing on OSX locally).
cc @TheMarex @springmeyer @willwhite