You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Related #6551
I know @SiarheiFedartsou mentioned elsewhere it's not good style in general to use both boost::optional and std::optional in the same codebase. The removal is delayed due to spirit::qi and phoenix incompatiblity with std::optional. This would involve adpapting the current parsers (3 ones) completely new in x3, but I do have some progress in my fork.
Also for removing phoenix as per docs "Define small unnamed function objects at the actual call site" seems like something one would want to remove for a cleaner codebase and I can see it only being used in conjunction with qi so migrating to x3 would make it obsolete.
The text was updated successfully, but these errors were encountered:
mugr1x
pushed a commit
to mugr1x/osrm
that referenced
this issue
Apr 3, 2023
Related #6551
I know @SiarheiFedartsou mentioned elsewhere it's not good style in general to use both boost::optional and std::optional in the same codebase. The removal is delayed due to spirit::qi and phoenix incompatiblity with std::optional. This would involve adpapting the current parsers (3 ones) completely new in x3, but I do have some progress in my fork.
Also for removing phoenix as per docs "Define small unnamed function objects at the actual call site" seems like something one would want to remove for a cleaner codebase and I can see it only being used in conjunction with qi so migrating to x3 would make it obsolete.
The text was updated successfully, but these errors were encountered: