Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove boost::phoenix and migrate from boost::spirit::qi to boost::spirit::x3 #6592

Closed
mugr1x opened this issue Apr 3, 2023 · 1 comment
Closed

Comments

@mugr1x
Copy link
Contributor

mugr1x commented Apr 3, 2023

Related #6551
I know @SiarheiFedartsou mentioned elsewhere it's not good style in general to use both boost::optional and std::optional in the same codebase. The removal is delayed due to spirit::qi and phoenix incompatiblity with std::optional. This would involve adpapting the current parsers (3 ones) completely new in x3, but I do have some progress in my fork.
Also for removing phoenix as per docs "Define small unnamed function objects at the actual call site" seems like something one would want to remove for a cleaner codebase and I can see it only being used in conjunction with qi so migrating to x3 would make it obsolete.

@mugr1x
Copy link
Contributor Author

mugr1x commented Apr 3, 2023

Also I should probably mention I applied for GSoC 2023 (;
Indeed this one: #6558

@mugr1x mugr1x closed this as not planned Won't fix, can't repro, duplicate, stale Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant