-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn angle calculation needs to respect initial road order #4331
Comments
Turns out, that the fork handler already assigns (slight) left/right only. There seems to be a mixup in turn-angle computation here. |
My findings show that the main problem at the given intersection is that multiple version of turn angle calculation interact badly with each other given the very small angle where the roads actually turn. To fix this, we need to ensure that the initial order of turn angles is kept when changing computation from looking at the very first coordinate to some more advanced modelling. |
Is there any lingering work here? Appears that with #4332 merged this should be closed. |
When a fork turns, simply using the turn angle to compute the direction modifier can result in misleading directions. Forks should be hard limited to
left
andright
to distinguish between the two possibilities, ignoring the actual turn angle.osrm link
The text was updated successfully, but these errors were encountered: