Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn angle calculation needs to respect initial road order #4331

Closed
MoKob opened this issue Jul 25, 2017 · 4 comments · Fixed by #4443
Closed

Turn angle calculation needs to respect initial road order #4331

MoKob opened this issue Jul 25, 2017 · 4 comments · Fixed by #4443
Assignees
Milestone

Comments

@MoKob
Copy link

MoKob commented Jul 25, 2017

screen shot 2017-07-25 at 09 03 42

When a fork turns, simply using the turn angle to compute the direction modifier can result in misleading directions. Forks should be hard limited to left and right to distinguish between the two possibilities, ignoring the actual turn angle.

osrm link

@MoKob
Copy link
Author

MoKob commented Jul 25, 2017

Turns out, that the fork handler already assigns (slight) left/right only. There seems to be a mixup in turn-angle computation here.

@MoKob MoKob changed the title Irritating modifier on turning forks Turn angle calculation needs to respect initial road order Jul 25, 2017
@MoKob
Copy link
Author

MoKob commented Jul 25, 2017

My findings show that the main problem at the given intersection is that multiple version of turn angle calculation interact badly with each other given the very small angle where the roads actually turn.

To fix this, we need to ensure that the initial order of turn angles is kept when changing computation from looking at the very first coordinate to some more advanced modelling.

@miccolis
Copy link
Contributor

miccolis commented Sep 5, 2017

Is there any lingering work here? Appears that with #4332 merged this should be closed.

@MoKob
Copy link
Author

MoKob commented Sep 18, 2017

To capture the state here: #4332 was only a symptomatic fix. @oxidase has prepared a correct fix in #4443 which is currently up for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants