-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MONAI Deploy Application Server #9
Conversation
e66a199
to
efe7df1
Compare
/CC @KarthikMasi @bhatt-piyush to review and provide feedback. |
efe7df1
to
9235a2a
Compare
b8dafaf
to
67314a8
Compare
Similar comments for this as for the MAP PR #7 : We need to decide if this is a Guideline or Feature, in case this is a feature I'll propose the following changes on this: change the branch name to be:
cc @hshuaib90 |
Similar to comment I made for #7, the primary output of this PR is a document rather than code and as such it should be classified as Guideline. |
67314a8
to
ec60323
Compare
@ristoh @hshuaib90 please see my comment on #7 as well. I think we're heading down the wrong path here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These requirements are a good start but I do not think they cover the requirements we have already discussed in our WG meetings. I think we should at least cover those in 0.1 release.
I would also propose amending the document name to MONAI-App-Server-Requirements.md
@hshuaib90 can you expand on your statement?
|
For example, we have discussed the requirement to have the ability to execute nondeterministic chains or DAGs made up of individual applications, as well was things like facilitating the sending of results to clinical information systems such as Picture Archiving and Communication Systems. There is a helpful diagram that Jorge added here: https://docs.google.com/document/d/1fzG3z7TxB9SzWdfqsApAMFrM91nHfYiISnSz4QHJHrM/edit#heading=h.677zfo5wg7au |
While that has been a discussion point, I feel it is well outside the scope of the initial version of the Application Server. Functionality such as this would require a much more elaborate specification, design, and investment than we can likely make with the initial version.
Again, outside the scope of the Application Server. The goal of the Application Server is to serve applications on demand based on requests from external entities (PACS, users, etc.). What you're describing here sounds very much like the "infomatics gateway" @rahul-imaging describes, which is a separate service which sits along side the Application Server. Please let me know if I am making sense, or (likely) not quite understanding something and missing the point. 🙂 |
d05c661
to
484a123
Compare
68ca956
to
dd2ff86
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We discussed via Teams a few select changes, mostly around making everything into bullet points or numbered lists. Assuming those changes are made, I'm good with this.
dd2ff86
to
8d2b4be
Compare
a5247f6
to
205ee4e
Compare
205ee4e
to
259af73
Compare
This PR adds a draft of the MONAI Deploy App Server specification.
This contains a description of the initial set of requirements and design for MONAI Deploy App Server.