-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add utils for vista3d #7999
Merged
yiheng-wang-nv
merged 31 commits into
Project-MONAI:dev
from
yiheng-wang-nv:add-utils-for-vista3d
Aug 9, 2024
Merged
Add utils for vista3d #7999
yiheng-wang-nv
merged 31 commits into
Project-MONAI:dev
from
yiheng-wang-nv:add-utils-for-vista3d
Aug 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yiheng Wang <[email protected]>
Signed-off-by: Yiheng Wang <[email protected]>
Signed-off-by: Yiheng Wang <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: Yiheng Wang <[email protected]>
…to enhance-mlpblock
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: Yiheng Wang <[email protected]>
yiheng-wang-nv
commented
Aug 7, 2024
yiheng-wang-nv
commented
Aug 7, 2024
ericspod
reviewed
Aug 7, 2024
ericspod
reviewed
Aug 7, 2024
ericspod
reviewed
Aug 7, 2024
I had very minor suggestions but otherwise looks fine. |
Co-authored-by: Eric Kerfoot <[email protected]> Signed-off-by: Yiheng Wang <[email protected]>
Signed-off-by: Yiheng Wang <[email protected]>
…AI into add-utils-for-vista3d
Signed-off-by: Yiheng Wang <[email protected]>
Signed-off-by: Yiheng Wang <[email protected]>
yiheng-wang-nv
commented
Aug 8, 2024
Signed-off-by: Yiheng Wang <[email protected]>
…AI into add-utils-for-vista3d
yiheng-wang-nv
commented
Aug 8, 2024
yiheng-wang-nv
commented
Aug 8, 2024
Signed-off-by: Yiheng Wang <[email protected]>
Signed-off-by: Yiheng Wang <[email protected]>
KumoLiu
reviewed
Aug 9, 2024
KumoLiu
approved these changes
Aug 9, 2024
Co-authored-by: YunLiu <[email protected]> Signed-off-by: Yiheng Wang <[email protected]>
Signed-off-by: Yiheng Wang <[email protected]>
Signed-off-by: Yiheng Wang <[email protected]>
/build |
Hi @yiheng-wang-nv, please help take a look at the ci error.
|
Signed-off-by: Yiheng Wang <[email protected]>
…AI into add-utils-for-vista3d
/build |
rcremese
pushed a commit
to rcremese/MONAI
that referenced
this pull request
Sep 2, 2024
This PR is a part of Project-MONAI#7987 ### Description A few sentences describing the changes proposed in this pull request. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [x] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [x] In-line docstrings updated. - [x] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: Yiheng Wang <[email protected]> Signed-off-by: YunLiu <[email protected]> Signed-off-by: Yiheng Wang <[email protected]> Co-authored-by: YunLiu <[email protected]> Co-authored-by: Eric Kerfoot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a part of #7987
Description
A few sentences describing the changes proposed in this pull request.
Types of changes
./runtests.sh -f -u --net --coverage
../runtests.sh --quick --unittests --disttests
.make html
command in thedocs/
folder.