Fix deprecated argument in 'scipy.sparse.linalg.cg' #7897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: YunLiu <[email protected]>
ericspod
approved these changes
Jul 2, 2024
mingxin-zheng
approved these changes
Jul 2, 2024
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
|
/build |
Signed-off-by: YunLiu <[email protected]>
|
/build |
1 similar comment
|
/build |
|
Hi @ericspod and @Nic-Ma, I dropped Python3.8 test in ".github/workflows/pythonapp.yml" since scipy requires Python>=3.9. Since 3.8 has come to an end, do you have any concern on this change? |
|
/build |
1 similar comment
|
/build |
|
/build |
Signed-off-by: YunLiu <[email protected]>
Nic-Ma
approved these changes
Jul 2, 2024
|
/build |
Signed-off-by: YunLiu <[email protected]>
|
/build |
1 similar comment
|
/build |
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
for more information, see https://pre-commit.ci
|
/build |
|
Add a numpy version requirement as a workaround in this commit: 5ce2be9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7896
Description
'scipy.sparse.linalg.cg' keyword argument
tolis deprecated in favor ofrtoland will be removed in SciPy v1.14.0. Until then, if set, it will overridertol. So update to usertolincg.Drop python 3.8 test in packaging and premerge-gpu-test.
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.