Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monai generative: refactor autoencoderkl #7552

Merged

Adds 3d cases

a3bc49e
Select commit
Loading
Failed to load commit list.
Merged

monai generative: refactor autoencoderkl #7552

Adds 3d cases
a3bc49e
Select commit
Loading
Failed to load commit list.
DCO / DCO required action Apr 22, 2024 in 0s

DCO

There are 8 commits incorrectly signed off. This means that the author(s) of these commits failed to include a Signed-off-by line in their commit message.

To avoid having PRs blocked in the future, always include Signed-off-by: Author Name <[email protected]> in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).

Here is how to fix the problem so that this code can be merged.


Preferred method: Commit author adds a DCO remediation commit

A DCO Remediation Commit contains special text in the commit message that applies a missing Signed-off-by line in a subsequent commit. The primary benefit of this method is that the project’s history does not change, and there is no risk of breaking someone else’s work.

These authors can unblock this PR by adding a new commit to this branch with the following text in their commit message:

binliunls <[email protected]>

DCO Remediation Commit for binliunls <[email protected]>

I, binliunls <[email protected]>, hereby add my Signed-off-by to this commit: 01a0ee1cc2c6f97b690cd0c04222d60d01198df7

Signed-off-by: binliunls <[email protected]>

Kaibo Tang <[email protected]>

DCO Remediation Commit for Kaibo Tang <[email protected]>

I, Kaibo Tang <[email protected]>, hereby add my Signed-off-by to this commit: d5585c34fc44f46af9ffb28522ce44c7ed869654
I, Kaibo Tang <[email protected]>, hereby add my Signed-off-by to this commit: e1ffa7ebd38963bdced326d86979f5a9e2851517

Signed-off-by: Kaibo Tang <[email protected]>

Mark Graham <[email protected]>

DCO Remediation Commit for Mark Graham <[email protected]>

I, Mark Graham <[email protected]>, hereby add my Signed-off-by to this commit: 46c39dcf08676377288bb9295c859050a9b01de1

Signed-off-by: Mark Graham <[email protected]>

Yufan He <[email protected]>

DCO Remediation Commit for Yufan He <[email protected]>

I, Yufan He <[email protected]>, hereby add my Signed-off-by to this commit: 82124587c20eb5f86af2a8667fbc075978bc110b

Signed-off-by: Yufan He <[email protected]>

YunLiu <[email protected]>

DCO Remediation Commit for YunLiu <[email protected]>

I, YunLiu <[email protected]>, hereby add my Signed-off-by to this commit: 2fc012687f428c7dacbc14e5d57e92d5d5f49013
I, YunLiu <[email protected]>, hereby add my Signed-off-by to this commit: 88f8dd275dbe8ca856b45ca34d6d01f4ea4c0128
I, YunLiu <[email protected]>, hereby add my Signed-off-by to this commit: f5327ad59a996508d6ca52a505ab798a98289987

Signed-off-by: YunLiu <[email protected]>

Please note: You should avoid adding empty commits (i.e., git commit -s --allow-empty), because these will be discarded if someone rebases the branch / repo.


Least preferred method: Rebase the branch

If you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing").

You should only do this if:

  • You are the only author of the commits in this branch
  • You are absolutely certain nobody else is doing any work based upon this branch
  • There are no empty commits in the branch (for example, a DCO Remediation Commit which was added using --allow-empty)

To add your Signed-off-by line to every commit in this branch:

  1. Ensure you have a local copy of your branch by checking out the pull request locally via command line.
  2. In your local branch, run: git rebase HEAD~52 --signoff
  3. Force push your changes to overwrite the branch: git push --force-with-lease origin 7227_refactor_autoencoderkl

Summary

Commit sha: 01a0ee1, Author: binliunls, Committer: GitHub; Expected "binliunls [email protected]", but got "binliu [email protected]".
Commit sha: d5585c3, Author: Kaibo Tang, Committer: GitHub; Expected "Kaibo Tang [email protected]", but got "kaibo [email protected]".
Commit sha: e1ffa7e, Author: Kaibo Tang, Committer: GitHub; Expected "Kaibo Tang [email protected]", but got "kaibo [email protected]".
Commit sha: 46c39dc, Author: Mark Graham, Committer: Mark Graham; The sign-off is missing.
Commit sha: 8212458, Author: Yufan He, Committer: GitHub; Expected "Yufan He [email protected]", but got "heyufan1995 [email protected]".
Commit sha: 2fc0126, Author: YunLiu, Committer: GitHub; Expected "YunLiu [email protected]", but got "KumoLiu [email protected]".
Commit sha: 88f8dd2, Author: YunLiu, Committer: GitHub; Expected "YunLiu [email protected]", but got "KumoLiu [email protected]".
Commit sha: f5327ad, Author: YunLiu, Committer: GitHub; The sign-off is missing.