7047 simplify resnet pretrained

[vgrau98]

Fixes #7047

Description

Resnet did not support True value (not implemented ) for its pretrained flag.
2 implemented behavior:

• When pretrained is True, download weights from https://huggingface.co/TencentMedicalNet
• When pretrained is a string, loads weights from the path defined by the string

Types of changes

• Non-breaking change (fix or new feature that would not break existing functionality).
• Breaking change (fix or new feature that would cause existing functionality to change).
• New tests added to cover the changes.
• Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
• Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
• In-line docstrings updated.
• Documentation updated, tested make html command in the docs/ folder.

[vgrau98]

Not sure about good practices in added test

[vgrau98]

Documentation should be updated too

[vgrau98]

test_resnet gives errors, all the tests i wrote don't seem to be unitary, there's an integration part with the huggingface api. I'll try to fix this quickly by creating integration tests in the dedicated test_integration_resnet.py file. Maybe the test environment is not the same between unit and integration tests ?

[wyli]

/black

test_resnet gives errors, all the tests i wrote don't seem to be unitary, there's an integration part with the huggingface api. I'll try to fix this quickly by creating integration tests in the dedicated test_integration_resnet.py file. Maybe the test environment is not the same between unit and integration tests ?

thanks, please follow this guide for adding new dep https://github.com/Project-MONAI/MONAI/blob/dev/CONTRIBUTING.md#adding-new-optional-dependencies

I think the current unit test looks great, we just need to somehow pin down a specific commit hash of the model version, then I don't see much risk of regression.

[vgrau98]

test_resnet gives errors, all the tests i wrote don't seem to be unitary, there's an integration part with the huggingface api. I'll try to fix this quickly by creating integration tests in the dedicated test_integration_resnet.py file. Maybe the test environment is not the same between unit and integration tests ?

thanks, please follow this guide for adding new dep https://github.com/Project-MONAI/MONAI/blob/dev/CONTRIBUTING.md#adding-new-optional-dependencies

I think the current unit test looks great, we just need to somehow pin down a specific commit hash of the model version, then I don't see much risk of regression.

Yes sorry my bad, didn't read the doc carefully enough, should be fixed now

[KumoLiu]

Looks good to me, several minor comments inline.
Could you please also fix the format ci error?
https://github.com/Project-MONAI/MONAI/blob/dev/CONTRIBUTING.md#checking-the-coding-style

[wyli]

/build

[wyli]

/build

[wyli]

thanks! trying to merge this pr for more integration tests

[wyli]

/build