Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

7042 collate common meta dictionary keys #7054

Merged
merged 1 commit into from
Sep 27, 2023
Merged

7042 collate common meta dictionary keys #7054

merged 1 commit into from
Sep 27, 2023

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Sep 26, 2023 •
edited
Loading

Fixes #7042

  • handling inconsistent meta keys when collating metatensor

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli wyli requested review from ericspod, Nic-Ma and KumoLiu September 26, 2023 20:53
@wyli wyli marked this pull request as ready for review September 26, 2023 20:53
KumoLiu
KumoLiu approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@KumoLiu KumoLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, looks good to me.

@wyli
Copy link
Contributor Author

wyli commented Sep 27, 2023

/build

@wyli wyli enabled auto-merge (squash) September 27, 2023 07:58
@wyli wyli merged commit a29ab04 into Project-MONAI:dev Sep 27, 2023
26 checks passed
@wyli wyli deleted the 7042-collate branch October 1, 2023 14:14
@KumoLiu KumoLiu mentioned this pull request Oct 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KumoLiu KumoLiu KumoLiu approved these changes

@ericspod ericspod Awaiting requested review from ericspod

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wyli @KumoLiu