Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancing get_all_bundles_list under monai.bundle to support model zoo NGC hosting #6997

Merged
merged 12 commits into from
Sep 18, 2023
Merged

Enhancing get_all_bundles_list under monai.bundle to support model zoo NGC hosting #6997

merged 12 commits into from
Sep 18, 2023

Conversation

KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Sep 18, 2023 •
edited
Loading

Fixes #6833

Description

Add model_info_url in get_all_bundles_list, get_bundle_versions, and get_bundle_info.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@KumoLiu
fix Project-MONAI#6833
546d6c0 
Signed-off-by: KumoLiu <[email protected]>
@KumoLiu
address comments
1bd68e9 
Signed-off-by: KumoLiu <[email protected]>
@KumoLiu
minor fix
e269b48 
Signed-off-by: KumoLiu <[email protected]>
wyli
wyli reviewed Sep 18, 2023
View reviewed changes
monai/bundle/scripts.py Outdated Show resolved Hide resolved
ericspod
ericspod reviewed Sep 18, 2023
View reviewed changes
monai/bundle/scripts.py Outdated Show resolved Hide resolved
ericspod
ericspod reviewed Sep 18, 2023
View reviewed changes
monai/bundle/scripts.py Outdated Show resolved Hide resolved
ericspod
ericspod reviewed Sep 18, 2023
View reviewed changes
monai/bundle/scripts.py Outdated Show resolved Hide resolved
KumoLiu and others added 7 commits September 18, 2023 20:33
ericspod
ericspod reviewed Sep 18, 2023
View reviewed changes
monai/bundle/scripts.py Outdated Show resolved Hide resolved
@KumoLiu
address comments
250e4c0 
Signed-off-by: KumoLiu <[email protected]>
ericspod
ericspod approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@ericspod ericspod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks!

@wyli
Copy link
Contributor

wyli commented Sep 18, 2023

/build

@wyli wyli enabled auto-merge (squash) September 18, 2023 13:46
@wyli wyli merged commit 73a7601 into Project-MONAI:dev Sep 18, 2023
25 of 30 checks passed
@KumoLiu KumoLiu deleted the get-all-bundle branch September 18, 2023 14:55
@wyli wyli mentioned this pull request Sep 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyli wyli wyli left review comments

@ericspod ericspod ericspod approved these changes

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma

@yiheng-wang-nv yiheng-wang-nv Awaiting requested review from yiheng-wang-nv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancing get_all_bundles_list under monai.bundle to support model zoo NGC hosting
3 participants
@KumoLiu @wyli @ericspod