Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #6630 #6660

Merged
merged 2 commits into from
Jun 27, 2023
Merged

fix #6630 #6660

merged 2 commits into from
Jun 27, 2023

Conversation

function2-llx
Copy link
Contributor

@function2-llx function2-llx commented Jun 27, 2023

Fixes #6630.

Description

Fix DICOM series combining checking

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.

Signed-off-by: function2 <[email protected]>
@function2-llx function2-llx force-pushed the 6630-fix-dcm-meta-combine branch from 9e2a0db to d246bbf Compare June 27, 2023 02:25
@function2-llx
Copy link
Contributor Author

By the way, the reference link of ITK here:

if Path(name).is_dir():
# read DICOM series
# https://itk.org/ITKExamples/src/IO/GDCM/ReadDICOMSeriesAndWrite3DImage
names_generator = itk.GDCMSeriesFileNames.New()
names_generator.SetUseSeriesDetails(True)

seems to be broken, and migrate to https://examples.itk.org/src/io/gdcm/readdicomseriesandwrite3dimage/documentation.

@function2-llx function2-llx marked this pull request as ready for review June 27, 2023 05:13
@function2-llx function2-llx changed the title [WIP] fix #6630 fix #6630 Jun 27, 2023
@KumoLiu
Copy link
Contributor

KumoLiu commented Jun 27, 2023

By the way, the reference link of ITK here:

if Path(name).is_dir():
# read DICOM series
# https://itk.org/ITKExamples/src/IO/GDCM/ReadDICOMSeriesAndWrite3DImage
names_generator = itk.GDCMSeriesFileNames.New()
names_generator.SetUseSeriesDetails(True)

seems to be broken, and migrate to https://examples.itk.org/src/io/gdcm/readdicomseriesandwrite3dimage/documentation.

Yes, you are right. Could you please help also update it in this PR?
Thanks in advance!

@function2-llx
Copy link
Contributor Author

By the way, the reference link of ITK here:

if Path(name).is_dir():
# read DICOM series
# https://itk.org/ITKExamples/src/IO/GDCM/ReadDICOMSeriesAndWrite3DImage
names_generator = itk.GDCMSeriesFileNames.New()
names_generator.SetUseSeriesDetails(True)

seems to be broken, and migrate to examples.itk.org/src/io/gdcm/readdicomseriesandwrite3dimage/documentation.

Yes, you are right. Could you please help also update it in this PR? Thanks in advance!

Sure thing. I've updated two ITK reference links.

Copy link
Contributor

@KumoLiu KumoLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick update, LGTM.

@KumoLiu KumoLiu requested review from wyli and yiheng-wang-nv June 27, 2023 05:50
@wyli
Copy link
Contributor

wyli commented Jun 27, 2023

/build

@wyli wyli enabled auto-merge (squash) June 27, 2023 05:54
@wyli wyli merged commit 8bc25b9 into Project-MONAI:dev Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong spacing checking logic in DICOM series combination
3 participants