Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set autoscale false for auto3dseg test #6529

Merged
merged 3 commits into from
May 22, 2023

Conversation

heyufan1995
Copy link
Member

Fixes # .
Disabled autoscale for auto3dseg template testing.

Description

A few sentences describing the changes proposed in this pull request.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@heyufan1995 heyufan1995 requested a review from wyli May 18, 2023 12:57
@wyli
Copy link
Contributor

wyli commented May 18, 2023

/integration-test
/black

Signed-off-by: monai-bot <[email protected]>
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mingxin-zheng please let me know if any concerns

@mingxin-zheng
Copy link
Contributor

The changes are only in HPO, which I think it should be fine.
My question to @heyufan1995 would be whether it is necessary to keep the auto scaling off in all unit tests, as we strived to use the minimal resources in the unit test and avoid overloading the testing systems.

@wyli
Copy link
Contributor

wyli commented May 19, 2023

/build

@wyli
Copy link
Contributor

wyli commented May 22, 2023

/build

merging this for now as the premerge tests now took too much time

[2023-05-22T15:39:36.575Z] test_run_algo (tests.test_auto3dseg_hpo.TestHPO) (2.31e+02s)
[2023-05-22T15:39:36.575Z] test_get_history (tests.test_auto3dseg_hpo.TestHPO) (4.29e+02s)
[2023-05-22T15:39:36.575Z] test_run_optuna (tests.test_auto3dseg_hpo.TestHPO) (8.32e+02s)

this PR simplify the tests. I've also created a ticket to #6539

@wyli wyli enabled auto-merge (squash) May 22, 2023 15:46
@wyli wyli merged commit 960249f into Project-MONAI:dev May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants