Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FROC metric in ND #6528

Merged
merged 3 commits into from
May 24, 2023
Merged

FROC metric in ND #6528

merged 3 commits into from
May 24, 2023

Conversation

kretes
Copy link
Contributor

@kretes kretes commented May 18, 2023

Fixes #5172 .

Description

Implementation of FROC metric in ND

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.

kretes added 2 commits May 18, 2023 09:36
@kretes
FROC metric in ND
b15768f 
Signed-off-by: Tomasz Bartczak <[email protected]>
@kretes
code style fix in FROC
ff67575 
Signed-off-by: Tomasz Bartczak <[email protected]>
wyli
wyli approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me.

@wyli
Copy link
Contributor

wyli commented May 19, 2023

/build

@wyli wyli enabled auto-merge (squash) May 19, 2023 08:31
@wyli wyli disabled auto-merge May 19, 2023 08:32
@wyli
Copy link
Contributor

wyli commented May 24, 2023

/build

@wyli wyli enabled auto-merge (squash) May 24, 2023 20:47
@wyli wyli merged commit 8494029 into Project-MONAI:dev May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyli wyli wyli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FROC metrics for 3D data
2 participants
@kretes @wyli