Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6463 Optimized the deepcopy logic in ConfigParser #6464

Merged
merged 9 commits into from
May 4, 2023

Conversation

Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented May 4, 2023

Fixes #6463 .

Description

This PR optimized the deepcopy logic in ConfigParser to avoid the problems in #6463 .

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented May 4, 2023

/black

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented May 4, 2023

/build

@ericspod
Copy link
Member

ericspod commented May 4, 2023

This looks correct to me from going over the code, is there any way to test this with model zoo bundles? I can't imagine where a bundle would rely on objects always being deep copied (and so now would break) but if they did this would be a difficult issue to spot.

Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works fine with the premerge tests, let's merge to have more tests...

@wyli wyli merged commit 25c9c39 into Project-MONAI:dev May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ConfigParser doesn't need deepcopy
3 participants