-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6463 Optimized the deepcopy
logic in ConfigParser
#6464
Conversation
merge master
merge master
merge master
merge master
merge master
merge master
merge master
Signed-off-by: Nic Ma <[email protected]>
/black |
/build |
This looks correct to me from going over the code, is there any way to test this with model zoo bundles? I can't imagine where a bundle would rely on objects always being deep copied (and so now would break) but if they did this would be a difficult issue to spot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works fine with the premerge tests, let's merge to have more tests...
Fixes #6463 .
Description
This PR optimized the deepcopy logic in
ConfigParser
to avoid the problems in #6463 .Types of changes
./runtests.sh -f -u --net --coverage
../runtests.sh --quick --unittests --disttests
.make html
command in thedocs/
folder.