-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto3DSeg continue training (skip trained algos) #6310
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: myron <[email protected]>
Signed-off-by: myron <[email protected]>
Signed-off-by: myron <[email protected]>
myron
changed the title
Auto3DSeg continue training (skipp trained algos)
Auto3DSeg continue training (skip trained algos)
Apr 5, 2023
Signed-off-by: myron <[email protected]>
Signed-off-by: myron <[email protected]>
mingxin-zheng
approved these changes
Apr 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks!
Signed-off-by: Wenqi Li <[email protected]>
/build |
/build |
Signed-off-by: Wenqi Li <[email protected]>
/build |
wyli
approved these changes
Apr 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, verified that the integration tests work fine with this PR
This was referenced Apr 7, 2023
wyli
pushed a commit
to Project-MONAI/tutorials
that referenced
this pull request
Apr 13, 2023
algo_dict key updates this should be merged after updates in Project-MONAI/MONAI#6310 fixes #1306 --------- Signed-off-by: myron <[email protected]> Signed-off-by: Mingxin Zheng <[email protected]>
boneseva
pushed a commit
to boneseva/MONAI-tutorials
that referenced
this pull request
Apr 21, 2024
algo_dict key updates this should be merged after updates in Project-MONAI/MONAI#6310 fixes Project-MONAI#1306 --------- Signed-off-by: myron <[email protected]> Signed-off-by: Mingxin Zheng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second PR for issue #6291
fixes #6291
Since the previous PR #6290 was reverted #6295
Allows to skip the already trained algos, and continue training only for the non-trained ones.
after this PR, the default option AutoRunner(train=None) will have this behavior, whereas manually setting AutoRunner(train=True/False) will always train all or skip all training. Previously we can only train all or skip all (without any option to resume)
I changed import_bundle_algo_history() to return a better algo_dict
previously it returned "list[dict(name: algo)]" - a list of dict, but each dict must have a single key name "name => algo". Not it returns a list of dicts, each with several keys dict(AlgoEnsembleKeys.ID: name, AlgoEnsembleKeys.ALGO, algo, "is_trained": bool, etc).
this allows to put additional metadata inside of each algo_dict, and it's easier to read it back.
previously, to get a name we had to use "name = history[0].keys()[0]", now it's more elegant "name = history[0][AlgoEnsembleKeys.ID]".
this however required to change many files, everywhere where import_bundle_algo_history and export_bundle_algo_history was used.
All the tests have passed, except for "integration GPU utilization tests" , but those errors seems unrelated
After this PR, tutorials need to be updated too Project-MONAI/tutorials#1288