-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
warn or raise ValueError on duplicated key in json/yaml config #6252
Conversation
Signed-off-by: Tomasz Bartczak <[email protected]>
Signed-off-by: Tomasz Bartczak <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Tomasz Bartczak <[email protected]>
Thanks, I think we can make it a warning be default, and provide an option to raise an exception. Cc @Nic-Ma |
Signed-off-by: Tomasz Bartczak <[email protected]>
I've made it a warning by default and error only when a specific env variable is set. LMK if this is ok and then I can extend it to yaml. |
thanks, looks good to me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, put some minor comments inline.
Thanks.
Signed-off-by: Tomasz Bartczak <[email protected]>
Signed-off-by: Tomasz Bartczak <[email protected]>
Signed-off-by: Tomasz Bartczak <[email protected]>
Signed-off-by: Tomasz Bartczak <[email protected]>
/build |
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
/build |
Fixes #5471 .
Description
[WIP]
Monai will now raise an error whenever there is a duplicated key in any of the config json files.
TBD:
Things to discuss:
Types of changes
./runtests.sh -f -u --net --coverage
. (I couldn't run them locally due to OOM)./runtests.sh --quick --unittests --disttests
.Documentation updated, testedI think that's a safeguard that doesn't require explicit documentationmake html
command in thedocs/
folder.