Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MONAI] Add whole image deform support in Rand3DElasticd #623

Merged
merged 4 commits into from
Jun 25, 2020

Conversation

wentaozhu
Copy link
Contributor

Fixes # .

Description

Add whole image deform support in Rand3DElasticd

Status

Ready

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or new feature that would cause existing functionality to change)
  • New tests added to cover the changes
  • Docstrings/Documentation updated

+ Rand3DElasticd supports whole image deform
+ add whole image deform example (-1, -1, -1)
@wyli wyli self-requested a review June 25, 2020 18:43
@wyli
Copy link
Contributor

wyli commented Jun 25, 2020

thanks, please consider updating the 2D version for the same https://github.com/Project-MONAI/MONAI/blob/0.2.0rc1/monai/transforms/spatial/dictionary.py#L420-L423

the relevant unit test is in: tests/test_rand_elasticd_2d.py

wentaozhu added a commit to wentaozhu/MONAI that referenced this pull request Jun 25, 2020
+ Add full image deform augmentation by Rand3DElasticd
+ Please use latest MONAI in Project-MONAI#623
@wentaozhu
Copy link
Contributor Author

@wyli Thank you so much!

@wyli wyli merged commit 2516f80 into Project-MONAI:master Jun 25, 2020
wyli pushed a commit to wyli/MONAI that referenced this pull request Jun 25, 2020
+ Add full image deform augmentation by Rand3DElasticd
+ Please use latest MONAI in Project-MONAI#623
Nic-Ma added a commit that referenced this pull request Jun 26, 2020
* adds network

* adds basic training

* update loading

* working prototype

* update validation set

* [MONAI] Add author; paper info; PDDCA18 (#6)

+ Author
+ Early accept
+ PDDCA18 link

* Update README.md

* adds network

* adds basic training

* update loading

* working prototype

* update validation set

* [MONAI] Update TRAIN_PATH, VAL_PATH (#8)

+ Update TRAIN_PATH, VAL_PATH

* [MONAI] Add data link (#7)

+ Add data link https://drive.google.com/file/d/1A2zpVlR3CkvtkJPvtAF3-MH0nr1WZ2Mn/view?usp=sharing

* fixes typos

* tested new dataset

* print more infor, checked new dataset

* [MONAI] Add paper link (#9)

Add paper link https://arxiv.org/abs/2006.12575

* [MONAI] Use dice loss + focal loss to train (#10)

Use dice loss + focal loss to train

* [MONAI] Support non-one-hot ground truth (#11)

Support non-one-hot ground truth

* fixes format and docstrings, adds argparser options

* resume the focal_loss

* adds tests

* [MONAI] Support non-one-hot ground truth (#11)

Support non-one-hot ground truth

* adds tests

* update docstring

* [MONAI] Keep track of best validation scores (#12)

Keep track of best validation scores

* model saving

* adds window sampling

* update readme

* update docs

* fixes flake8 error

* update window sampling

* fixes model name

* fixes channel size issue

* [MONAI] Update --pretrain, --lr (#13)

+ lr from 5e-4 to 1e-3 because we use mean for class channel instead of sum for class channel.
+ pretrain path is consistent with current model_name.

* [MONAI] Pad image; elastic; best class model (#14)

* [MONAI] Pad image; elastic; best class model

+ Pad image bigger than crop_size, avoid potential issues in RandCropByPosNegLabeld
+ Use Rand3DElasticd
+ Save best model for each class

* Update train.py

Co-authored-by: Wenqi Li <[email protected]>

* flake8 fixes

* removes -1 cropsize deform

* testing commands

* fixes unit tests

* update spatial padding

* [MONAI] Add full image deform augmentation (#15)

+ Add full image deform augmentation by Rand3DElasticd
+ Please use latest MONAI in #623

* Adding py.typed

* updating setup.py to comply with black

* update based on comments

* excluding research from packaging

* update tests

* update setup.py

Co-authored-by: Wentao Zhu <[email protected]>
Co-authored-by: Neil Tenenholtz <[email protected]>
Co-authored-by: Nic Ma <[email protected]>
@wyli wyli mentioned this pull request Jun 29, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants