Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6033 keep the gradient in sliding window utility when possible #6034

Merged
merged 3 commits into from
Feb 21, 2023

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Feb 21, 2023

Fixes #6033

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli wyli requested a review from ericspod February 21, 2023 13:25
@wyli
Copy link
Contributor Author

wyli commented Feb 21, 2023

/build

@wyli wyli enabled auto-merge (squash) February 21, 2023 14:28
Signed-off-by: Wenqi Li <[email protected]>
@wyli
Copy link
Contributor Author

wyli commented Feb 21, 2023

/build

@wyli
Copy link
Contributor Author

wyli commented Feb 21, 2023

/build

@wyli wyli merged commit 66422f8 into Project-MONAI:dev Feb 21, 2023
@wyli wyli deleted the diff-sliding-window branch February 21, 2023 19:47
mingxin-zheng pushed a commit to Project-MONAI/tutorials that referenced this pull request Feb 27, 2023
### Description
- Project-MONAI/MONAI#6034
- Project-MONAI/MONAI#6051

### Checks
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Avoid including large-size files in the PR.
- [x] Clean up long text outputs from code cells in the notebook.
- [x] For security purposes, please check the contents and remove any
sensitive info such as user names and private key.
- [x] Ensure (1) hyperlinks and markdown anchors are working (2) use
relative paths for tutorial repo files (3) put figure and graphs in the
`./figure` folder
- [x] Notebook runs automatically `./runner.sh -t <path to .ipynb file>`

---------

Signed-off-by: Wenqi Li <[email protected]>
boneseva pushed a commit to boneseva/MONAI-tutorials that referenced this pull request Apr 21, 2024
### Description
- Project-MONAI/MONAI#6034
- Project-MONAI/MONAI#6051

### Checks
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Avoid including large-size files in the PR.
- [x] Clean up long text outputs from code cells in the notebook.
- [x] For security purposes, please check the contents and remove any
sensitive info such as user names and private key.
- [x] Ensure (1) hyperlinks and markdown anchors are working (2) use
relative paths for tutorial repo files (3) put figure and graphs in the
`./figure` folder
- [x] Notebook runs automatically `./runner.sh -t <path to .ipynb file>`

---------

Signed-off-by: Wenqi Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sliding_window_inference shouldn't remove gradient
2 participants