-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5740 metrics reloaded support #5741
5740 metrics reloaded support #5741
Conversation
Signed-off-by: Mikael Brudfors <[email protected]>
Signed-off-by: Mikael Brudfors <[email protected]>
Signed-off-by: Mikael Brudfors <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Mikael Brudfors <[email protected]>
…nto 5740-metrics-reloaded-support
/black |
Signed-off-by: Mikael Brudfors <[email protected]>
Sounds good! This PR is limited to supporting the semantic segmentation metrics from MetricsReloaded and for that I cannot, for now, think of any improvements on the MONAI side. This might change when we integrate the instance segmentation and object detection metrics, later down the line. On the MetricsReloaded side, there are still some improvements that can be made, but I don't think they would require changing the API that MONAI uses. |
Signed-off-by: Mikael Brudfors <[email protected]>
Signed-off-by: Mikael Brudfors <[email protected]>
Signed-off-by: Mikael Brudfors <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Mikael Brudfors <[email protected]>
Signed-off-by: Mikael Brudfors <[email protected]>
…nto 5740-metrics-reloaded-support
Signed-off-by: monai-bot <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: monai-bot <[email protected]>
/build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll add the ignite wrapper in a separate pr
/build |
Signed-off-by: Mikael Brudfors [email protected]
part of #5740
Description
Makes the binary and categorical metrics from MetricsReloaded available in MONAI via a wrapper module (
monai/metrics/wrapper.py
).This module allows to use the MetricsReloaded metrics as, e.g.:
Tests of all metrics are in
tests/test_metrics_reloaded.py
.Note that MetricsReloaded is an optional dependency of MONAI; so in order to use the wrapper, MONAI needs to be installed with:
pip install '.[metricsreloaded]'
Types of changes
./runtests.sh -f -u --net --coverage
../runtests.sh --quick --unittests --disttests
.make html
command in thedocs/
folder.