Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cuCIM Transform #2932

Merged
merged 29 commits into from
Sep 16, 2021
Merged

cuCIM Transform #2932

merged 29 commits into from
Sep 16, 2021

Conversation

drbeh
Copy link
Member

@drbeh drbeh commented Sep 12, 2021

Description

This PR implements a wrapper for cuCIM transforms to be used in combination with MONAI transforms.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@drbeh
Copy link
Member Author

drbeh commented Sep 13, 2021

@wyli @Nic-Ma do you know why the min tests are failing?
https://github.com/Project-MONAI/MONAI/pull/2932/checks?check_run_id=3591023115#step:8:115

Is it because of following dependency?

if TYPE_CHECKING:
from cupy import ndarray as cp_ndarray
else:
cp_ndarray, _ = optional_import("cupy", name="ndarray")

Signed-off-by: Behrooz <[email protected]>
@Nic-Ma
Copy link
Contributor

Nic-Ma commented Sep 14, 2021

Hi @wyli ,

I remember we faced this error before, but I can't clearly remember the details.. Do you have any idea?

Thanks in advance.

@wyli
Copy link
Contributor

wyli commented Sep 14, 2021

@wyli @Nic-Ma do you know why the min tests are failing?
https://github.com/Project-MONAI/MONAI/pull/2932/checks?check_run_id=3591023115#step:8:115

Is it because of following dependency?

if TYPE_CHECKING:
from cupy import ndarray as cp_ndarray
else:
cp_ndarray, _ = optional_import("cupy", name="ndarray")

yes, cp_ndarray can't be used as a type annotation (such as def __call__(self, data: cp_ndarray):) because it'll be evaluated on some user environment and raise an error when there's no cupy installation.

@drbeh drbeh added this to the Performance enhancements 0.7.0 milestone Sep 14, 2021
@drbeh drbeh mentioned this pull request Sep 14, 2021
5 tasks
@drbeh drbeh marked this pull request as ready for review September 16, 2021 02:25
Signed-off-by: Behrooz <[email protected]>
@drbeh drbeh requested review from Nic-Ma and wyli September 16, 2021 02:34
@wyli wyli enabled auto-merge (squash) September 16, 2021 13:18
@wyli wyli merged commit 38403ed into Project-MONAI:dev Sep 16, 2021
@drbeh drbeh deleted the cucim-transform branch September 16, 2021 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants