-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
909 Update LoadImage to use Nibabel as default #1307
Conversation
merge master
merge master
[DLMED] fix torchscript issue in densenet (#1114)
Signed-off-by: Nic Ma <[email protected]>
/black |
Signed-off-by: monai-bot <[email protected]>
Signed-off-by: Nic Ma <[email protected]>
/black |
Hi @wyli , Thanks for your review, I updated the PR according to your comments. Thanks. |
Signed-off-by: Nic Ma <[email protected]>
/black |
Signed-off-by: Nic Ma <[email protected]>
/black |
Hi @wyli , I updated the PR to automatically select the default reader based on image type. Thanks. |
Signed-off-by: Nic Ma <[email protected]>
/black |
Signed-off-by: monai-bot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks I put some minor suggestions of using self.register
Signed-off-by: Nic Ma <[email protected]>
/integration-test /black |
Hi @wyli . Thanks for your suggestions, I updated the PR according to your comments. Thanks. |
Signed-off-by: Nic Ma <[email protected]>
/integration-test /black |
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, all tests upgraded to use the new API and tests work fine
Thanks for your update, I will try to update examples and tutorials soon. |
Partly fixes issue #909 .
Description
This PR implemented below features:
Change the default reader of LoadImage to Nibabel.
Add string support for the reader parameter.
Update all the examples and tutorials to use LoadImage transform.
Status
Ready
Types of changes
./runtests.sh --codeformat --coverage
../runtests.sh --quick
.make html
command in thedocs/
folder.