Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

909 Update LoadImage to use Nibabel as default #1307

Merged
merged 20 commits into from
Dec 2, 2020
Merged

909 Update LoadImage to use Nibabel as default #1307

merged 20 commits into from
Dec 2, 2020

Conversation

Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Dec 1, 2020

Partly fixes issue #909 .

Description

This PR implemented below features:
Change the default reader of LoadImage to Nibabel.
Add string support for the reader parameter.
Update all the examples and tutorials to use LoadImage transform.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh --codeformat --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Dec 1, 2020

/black

monai/transforms/io/array.py Outdated Show resolved Hide resolved
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Dec 1, 2020

/black

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Dec 1, 2020

Hi @wyli ,

Thanks for your review, I updated the PR according to your comments.
Could you please help review again?
We will try to update all the examples and tutorials when this PR is ready.

Thanks.

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Dec 1, 2020

/black

@Nic-Ma Nic-Ma requested a review from wyli December 1, 2020 14:13
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Dec 2, 2020

/black

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Dec 2, 2020

Hi @wyli ,

I updated the PR to automatically select the default reader based on image type.
Could you please help review it again?

Thanks.

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Dec 2, 2020

/black

Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks I put some minor suggestions of using self.register

monai/transforms/io/array.py Show resolved Hide resolved
monai/transforms/io/array.py Outdated Show resolved Hide resolved
monai/transforms/io/array.py Outdated Show resolved Hide resolved
monai/transforms/io/array.py Outdated Show resolved Hide resolved
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Dec 2, 2020

/integration-test /black

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Dec 2, 2020

Hi @wyli .

Thanks for your suggestions, I updated the PR according to your comments.
Could you please help review it again?

Thanks.

Signed-off-by: Nic Ma <[email protected]>
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Dec 2, 2020

/integration-test /black

Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, all tests upgraded to use the new API and tests work fine

@wyli wyli merged commit 2c903cd into Project-MONAI:master Dec 2, 2020
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Dec 2, 2020

Thanks for your update, I will try to update examples and tutorials soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants