-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect updated affine in NrrdReader
#7414
Comments
7 tasks
KumoLiu
added a commit
that referenced
this issue
Jan 25, 2024
…`ITKReader` (#7415) Fixes #7414 Fixes #7371 ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: YunLiu <[email protected]>
marksgraham
pushed a commit
to marksgraham/MONAI
that referenced
this issue
Jan 30, 2024
…`ITKReader` (Project-MONAI#7415) Fixes Project-MONAI#7414 Fixes Project-MONAI#7371 ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: YunLiu <[email protected]> Signed-off-by: Mark Graham <[email protected]>
juampatronics
pushed a commit
to juampatronics/MONAI
that referenced
this issue
Mar 25, 2024
…`ITKReader` (Project-MONAI#7415) Fixes Project-MONAI#7414 Fixes Project-MONAI#7371 ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: YunLiu <[email protected]> Signed-off-by: Juan Pablo de la Cruz Gutiérrez <[email protected]>
Yu0610
pushed a commit
to Yu0610/MONAI
that referenced
this issue
Apr 11, 2024
…`ITKReader` (Project-MONAI#7415) Fixes Project-MONAI#7414 Fixes Project-MONAI#7371 ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: YunLiu <[email protected]> Signed-off-by: Yu0610 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The docstring for
reverse_indexing
inITKReader
is wrong.MONAI/monai/data/image_reader.py
Lines 170 to 173 in abe2e31
MONAI/monai/data/image_reader.py
Lines 368 to 372 in abe2e31
https://github.com/InsightSoftwareConsortium/ITK/blob/f5aab1f68e53061264f4f6f3af5e0d49c5f7481d/Wrapping/Generators/Python/itk/support/extras.py#L351-L354
In
NrrdReader
, even the header have been updated after_convert_f_to_c_order
, it dosen't pass to the_get_affine
, so the affine is still not updated.MONAI/monai/data/image_reader.py
Lines 1324 to 1326 in abe2e31
The text was updated successfully, but these errors were encountered: