Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Early versions of isort incompatibility #6253

Closed
wyli opened this issue Mar 29, 2023 · 0 comments · Fixed by #6341, #6343 or #6344
Closed

Early versions of isort incompatibility #6253

wyli opened this issue Mar 29, 2023 · 0 comments · Fixed by #6341, #6343 or #6344
Labels
bug Something isn't working Low risk nice-to-have features

Comments

@wyli
Copy link
Contributor

wyli commented Mar 29, 2023

Describe the bug
Some early versions of isort are not compatible with the rest of the auto formatting tools,

MONAI/requirements-dev.txt

Line 23 in be3d138

isort

The requirement should have a minimal version constraint

Cc @myron
@wyli wyli added bug Something isn't working Low risk nice-to-have features labels Mar 29, 2023
wyli added a commit to wyli/MONAI that referenced this issue Apr 12, 2023
@wyli
fixes Project-MONAI#6253
46e52b1 
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli mentioned this issue Apr 12, 2023
Merged
7 tasks
wyli added a commit to wyli/MONAI that referenced this issue Apr 12, 2023
@wyli
fixes Project-MONAI#6253
1b763c5 
Signed-off-by: Wenqi Li <[email protected]>
wyli added a commit that referenced this issue Apr 12, 2023
@wyli
6340 update dtype for lazy resampling (#6341)
1ed59df 
Fixes #6340
Fixes #6253 

### Description


### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [x] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [x] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [x] In-line docstrings updated.
- [x] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli mentioned this issue Apr 12, 2023
Merged
7 tasks
wyli added a commit that referenced this issue Apr 12, 2023
@wyli @binliunls
merging 6339/6341 (#6343)
cb3ca6f 
closes #6339 (closes #6337)
closes #6341 (closes #6340 closes #6253)


### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [x] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: binliu <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Co-authored-by: binliunls <[email protected]>
@wyli wyli mentioned this issue Apr 12, 2023
Merged
@wyli wyli closed this as completed in 6b7b1e7 Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Low risk nice-to-have features
Projects
None yet
Milestone
No milestone
1 participant
@wyli