-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Potential 3D bug in EfficientNet Squeeze and Excitation layer #5574
Labels
Comments
agreed, would you like to contribute a fix? |
Great, yes. I'm new to Monai, are there any special instructions? |
Sure, the contributing guide has some details https://github.com/Project-MONAI/MONAI/blob/dev/CONTRIBUTING.md and please let me know if you have any specific questions |
7 tasks
Hi @yiheng-wang-nv could you please help fix this one, it seems #5695 had stalled. |
7 tasks
wyli
pushed a commit
that referenced
this issue
Jun 29, 2023
Fixes #5574 . ### Description This PR is used to fix the `MBConvBlock` issue when `spatial_dims` is not 2. The PR follows the work in: #5695 As it was not updated after review. Thanks @swilson314 for posting the issue! ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: Yiheng Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
efficientnet.py
I believe the image_size = [1, 1] in _make_same_padder() should actually be [1, 1, 1] for the EfficientNet to support 3D. This is just by inspection, but I suspect this oversight came from extending 2D code.
The text was updated successfully, but these errors were encountered: