Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding voxelmorph in MONAI? #5484

Closed
bhosalems opened this issue Nov 7, 2022 · 5 comments · Fixed by #7178
Closed

Adding voxelmorph in MONAI? #5484

bhosalems opened this issue Nov 7, 2022 · 5 comments · Fixed by #7178

Comments

@bhosalems
Copy link

Is your feature request related to a problem? Please describe.
Adding 3d image registration model called voxelmorph https://arxiv.org/pdf/1809.05231.pdf.

Describe the solution you'd like
Trainable voxelmorph model.

@wyli
Copy link
Contributor

wyli commented Nov 10, 2022

that's not currently implemented in this codebase, contributions is greatly welcomed.

@bhosalems
Copy link
Author

Thanks, I could add it as time permits. Can you point me to the right direction for contribution?

@aliunluml
Copy link

I will work on this if that's OK for both of you.

@aliunluml
Copy link

Ok. I am not able to work on this at the moment. If there is anyone else interested, please feel free to work on this.

@kvttt
Copy link
Contributor

kvttt commented Oct 30, 2023

Hi @wyli, may I work on this?

@kvttt kvttt mentioned this issue Nov 1, 2023
7 tasks
@wyli wyli closed this as completed in #7178 Nov 3, 2023
wyli pushed a commit that referenced this issue Nov 3, 2023
Fixes #5484.

### Description

Implemented VoxelMorph and added some docstrings. Checked coding style
locally.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [x] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [x] In-line docstrings updated.
- [x] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: kaibo <[email protected]>
marksgraham pushed a commit to marksgraham/MONAI that referenced this issue Jan 30, 2024
Fixes Project-MONAI#5484.

### Description

Implemented VoxelMorph and added some docstrings. Checked coding style
locally.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [x] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [x] In-line docstrings updated.
- [x] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: kaibo <[email protected]>
Signed-off-by: Mark Graham <[email protected]>
Yu0610 pushed a commit to Yu0610/MONAI that referenced this issue Apr 11, 2024
Fixes Project-MONAI#5484.

### Description

Implemented VoxelMorph and added some docstrings. Checked coding style
locally.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [x] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [x] In-line docstrings updated.
- [x] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: kaibo <[email protected]>
Signed-off-by: Yu0610 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants