Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken links in Team page #2

Closed
Squadrick opened this issue Jun 17, 2019 · 1 comment
Closed

Broken links in Team page #2

Squadrick opened this issue Jun 17, 2019 · 1 comment

Comments

@Squadrick
Copy link
Member

Squadrick commented Jun 17, 2019 •
edited
Loading

Most of the links under each person redirects to projectmanas.in especially for Facebook and Github.

The desirable behaviour would be to redirect to the correct link, and if the person doesn't have that service, to remove the corresponding icon.
trickarcher pushed a commit that referenced this issue Jun 17, 2019
Resolved Issue #2. Fixed Broken Links in Team Page.
4f59549
@trickarcher
Copy link
Collaborator

trickarcher commented Jun 17, 2019 •
edited
Loading

Fixed the Issue in the latest commit. There was an issue with the keyword empty, after replacing it by nil the issue was resolved. Also, fixed the issue where the Facebook links were being redirected to GitHub.
Check out this thread for more information about the conflict.

shrijitsingh99 pushed a commit that referenced this issue Jul 15, 2019
Resolved Issue #2. Fixed Broken Links in Team Page.
513d754 
Former-commit-id: 4f59549
trickarcher pushed a commit that referenced this issue Jul 23, 2019
Migrating to git lfs #2
21a004d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Squadrick @trickarcher