ChangeNotifierの実装(トークルームページ) #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thoth000
requested changes
Jul 21, 2020
| getMessageList(); | ||
| } | ||
| List<Message> messageList; | ||
| TextEditingController textController = TextEditingController(); |
There was a problem hiding this comment.
textControllerは変化する値ではない？と思ったので、TextFieldのあるクラスにおいていいと思います。
（textControllerに対して行われる関数は.clearだけなので…）
lib/ui/molecules/message/list.dart
Outdated
| @@ -1,69 +1,34 @@ | |||
| import 'package:chat_flutter/ui/molecules/message/list_item.dart'; | |||
| import 'package:chat_flutter/ui/pages/main/room/room_controller.dart'; | |||
| import 'package:flutter/material.dart'; | |||
| import 'package:chat_flutter/model/message.dart'; | |||
There was a problem hiding this comment.
import 'package:chat_flutter/model/message.dart';
ここの部分、使われていないので削除していいと思います！
Comment on lines
37
to
41
| void sendMessage() { | ||
| /// TODO Firebaseへの処理に置き換える | ||
| textController.clear(); | ||
| notifyListeners(); | ||
| } |
There was a problem hiding this comment.
textControllerをここのクラスに置かないのならば、
textController.textで文字列を受け取って、Firebaseでの処理のみにしたらいいと思います！
added 2 commits
July 22, 2020 10:57
thoth000
reviewed
Jul 22, 2020
| notifyListeners(); | ||
| } | ||
|
|
||
| Future<void> sendMessage(String message) { |
There was a problem hiding this comment.
ここはFutureなのでasyncつけた方が良いと思います！
There was a problem hiding this comment.
実装時に必要になるので、firebaseの実装時につけるでもいいですか？
|
自分のPR(#16 )のミスのせいなんですが、pages/mainというディレクトリがありますよね。 |
|
ディレクトリを移動するissueを作成して、ログ残すためにもまとめて整理した方がいい気がします！ |
thoth000
approved these changes
Jul 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue
#13
やったこと
・room_controllerの作成
・既存のroom.dartをcontrollerで置き換え
・textFieldの切り分け
懸念点
・TextEditingControllerをControllerに書き出して、controller経由でTextFieldを実装していますが、
このあたり自信ないので、もし意見あったらください！