Navigatorの整理 #14
Merged
Navigatorの整理 #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ho2ri2s
approved these changes
Jul 11, 2020
| MaterialPageRoute( | ||
| builder: (context) => RoomPage(room.name), | ||
| ), | ||
| '/roomPage', |
There was a problem hiding this comment.
ここ、ハードコーディングだとタイポする可能性あるかなーと思ったんですが、FlutterではConstとかで定義するんですかね？
優先順位的にそんなになので対応はおまかせします！
lib/ui/pages/profile.dart
Outdated
| @@ -76,7 +76,8 @@ class _ProfilePage extends StatelessWidget { | |||
| ), | |||
| label: Text("編集する"), | |||
| onPressed: () { | |||
| Navigator.pushNamed<void>(context, "/profileEditPage"); | |||
| Navigator.pushNamed<void>(context, "/profileEditPage", | |||
| arguments: "test"); | |||
There was a problem hiding this comment.
細かいですけど、�lib/ui/molecules/talk/list_tile.dart とインデント合わせるために "test", にしたさあります（笑）
|
インデントの部分のみ修正してpushしました！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue
#12
やったこと
lib/main.dartにページルートを定義した。Navigator.pushをNavigator.pushNamedに修正した。Navigator.pushNamedでargumentsとしてデータを渡すようにした。※
profile_edit.dartにも変更を加えたTextをTextFieldとし、名前の入力をできるようにした。ProfileImageにFlatButtonを親としてつけ、関数を実行できるようにした。