Chuy #34
Merged
Chuy #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlopezalvas
commented
May 27, 2023
| super(0,0,{ | ||
| cantColumnas: 10,cantFilas: 11}); | ||
| this.definirAnimacion("parado", | ||
| new Cuadros(5).repetirVeces(16) |
There was a problem hiding this comment.
Acá estaba el bug que hacía que se viera diferente, se estaba mostrando el cuadro 0 entre las animaciones. Puse el primer cuadro de la animación, en este caso el 5.
dlopezalvas
commented
May 27, 2023
Comment on lines
+32
to
+38
| puedeMoverseAbajo(){ | ||
| return this.tocandoFlechaAbajo() && !this.tieneEnLaCasillaDeAbajo("Obstaculo") | ||
| } | ||
|
|
||
| puedeMoverseDerecha(){ | ||
| return this.tocandoFlechaDerecha() && !this.tieneEnLaCasillaASuDerecha("Obstaculo") | ||
| } |
There was a problem hiding this comment.
Necesarios para los ejercicios de laberintos, tienen en cuenta los obstaculos para moverse, y si está en una última fila/columna no deja moverse (usando los tocandoFlecha de los ejercicios viejos)
dlopezalvas
commented
May 27, 2023
Comment on lines
+94
to
+101
| noHay(actor): boolean { | ||
| return this.contarActoresConEtiqueta(actor) == 0 | ||
| } | ||
|
|
||
| todosLosActoresCumplen(actor, estado) { | ||
| return this.obtenerActoresConEtiqueta(actor).every(o => o.nombreAnimacionActual() == estado); | ||
| } | ||
|
|
There was a problem hiding this comment.
Como se usan tanto con Yvoty, Chuy y Mañic, tenía más sentido ponerlos acá
dlopezalvas
commented
May 27, 2023
dlopezalvas
commented
May 27, 2023
Comment on lines
+84
to
+86
| noHayPelotas(): boolean { | ||
| return this.noHay("Pulpito") && this.noHay("PingPong") && this.todosLosActoresCumplen("PelotaAnimada", "patear") | ||
| } |
There was a problem hiding this comment.
Patear es el nombre de la animación que queda en la pelota una vez que fue pateada, no la cambie para no hacer lío
1 task
Co-authored-by: asanzo <[email protected]>
danielferro69
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Program-AR/pilas-bloques-ember#1306
pilas-bloques: Program-AR/pilas-bloques-ember#1337