Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PBError mas lindo #141

Merged
merged 2 commits into from
Nov 16, 2023
Merged

PBError mas lindo #141

merged 2 commits into from
Nov 16, 2023

Conversation

dlopezalvas
Copy link
Contributor

Resolves Program-AR/pilas-bloques-ember#1481

imagen

Me pareció más prolijo que el PBError tenga la lógica y que PageNotFound use PBError en lugar de que fuera al revés, asi que hice un pequeño refactor para ordenar esto.

Copy link
Contributor

@tfloxolodeiro tfloxolodeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

si

@dlopezalvas dlopezalvas merged commit 8d1ad4b into develop Nov 16, 2023
10 checks passed
@dlopezalvas dlopezalvas deleted the pb-error branch November 16, 2023 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PBError debería ser más bonito
2 participants