Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blockly warnings #136

Merged
merged 5 commits into from
Nov 14, 2023
Merged

Blockly warnings #136

merged 5 commits into from
Nov 14, 2023

Conversation

danielferro69
Copy link
Contributor

Resolves Program-AR/pilas-bloques-ember#1446
Resolves Program-AR/pilas-bloques-ember#1444

Esta rama esta derivada de Blockly por los cambios que produjeron el eject de CRA

Al hacer el eject se pudo agregar a la configuracion de webpack.config lo referente a Blockly para ingnorar sus warnings al levantar.

Los warnings de test estan tambien en este PR ya que el cambio para resolverlo es menor.

@danielferro69 danielferro69 requested a review from a team as a code owner November 10, 2023 16:33
@danielferro69 danielferro69 changed the base branch from develop to blockly November 10, 2023 16:35
Copy link
Contributor

@asanzo asanzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

11 archivos de configuración
3 archivos de scripts
4 dependencias nuevas

Da vértigo el eject, che. Son 14 archivos nuevos que mantener, sobre los cuales no entendemos mucho.

Espero que esta decisión salga bien 🤞

@danielferro69 danielferro69 merged commit 5f37d11 into blockly Nov 14, 2023
8 checks passed
@danielferro69 danielferro69 deleted the blockly-warnings branch November 14, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blockly - Warnings al levantar Blockly - Warnings de tests
2 participants